You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2013/07/23 01:57:28 UTC
[1/8] git commit: Remove the fadeIn() and fadeOut() EventWrapper
methods
Updated Branches:
refs/heads/master 4fd664d76 -> 1701e3b36
Remove the fadeIn() and fadeOut() EventWrapper methods
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/cddab131
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/cddab131
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/cddab131
Branch: refs/heads/master
Commit: cddab13132f3c09afd8f24b27439c554c147e8a7
Parents: 4fd664d
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 08:45:21 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 08:45:21 2013 -0700
----------------------------------------------------------------------
.../org/apache/tapestry5/t5-core-dom.coffee | 62 --------------------
1 file changed, 62 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/cddab131/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
index f2a90af..b7e9ab8 100644
--- a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
+++ b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
@@ -61,36 +61,6 @@ define ["underscore", "./utils", "./events", "jquery"],
element.dispatchEvent event
return not event.defaultPrevented
- # Currently don't want to rely on Scriptaculous, since our needs are pretty minor.
- animate = (element, styleName, initialValue, finalValue, duration, callbacks) ->
- styles = {}
- range = finalValue - initialValue
- initialTime = Date.now()
- first = true
- animator = ->
- elapsed = Date.now() - initialTime
- if elapsed >= duration
- styles[styleName] = finalValue
- element.setStyle styles
- window.clearInterval timeoutID
- callbacks.oncomplete and callbacks.oncomplete()
-
- # TODO: Add an easein/easeout function
-
- newValue = initialValue + range * (elapsed / duration)
- styles[styleName] = newValue
-
- element.setStyle styles
-
- if first
- callbacks.onstart and callbacks.onstart()
- first = false
-
- timeoutID = window.setInterval animator
-
- styles[styleName] = initialValue
- element.setStyle styles
-
# converts a selector to an array of DOM elements
parseSelectorToElements = (selector) ->
if _.isString selector
@@ -450,38 +420,6 @@ define ["underscore", "./utils", "./events", "jquery"],
return this
- # Runs an animation to fade-in the element over the specified duration.
- #
- # * duration - animation duration time, in seconds
- # * callback - function invoked after the animation is complete
- fadeIn: (duration, callback) ->
-#if jquery
- @$.fadeIn duration * 1000, ->
- callback and callback()
-#elseif prototype
- animate @element, "opacity", 0, 1, duration * 1000,
- onstart: => @element.show()
- oncomplete: callback
-#endif
-
- return this
-
- # Runs an animation to fade out an element over the specified duration. The element should already
- # be visible and fully opaque.
- #
- # * duration - animation duration time, in seconds
- # * callback - function invoked after the animation is complete
- fadeOut: (duration, callback) ->
-#if jquery
- @$.fadeOut duration * 1000, ->
- callback and callback()
-#elseif prototype
- animate @element, "opacity", 1, 0, duration * 1000,
- oncomplete: callback
-#endif
-
- return this
-
# Finds the first child element that matches the CSS selector, wrapped as an ElementWrapper.
# Returns null if not found.
findFirst: (selector) ->
[3/8] git commit: Hook requirejs.onError() to present RequireJS
errors in the floating console (if enabled)
Posted by hl...@apache.org.
Hook requirejs.onError() to present RequireJS errors in the floating console (if enabled)
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/2ce0b5a1
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/2ce0b5a1
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/2ce0b5a1
Branch: refs/heads/master
Commit: 2ce0b5a19fcdd4569af5c8b2ebc97d4e8f14803a
Parents: 2ec37ad
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 08:57:27 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 08:57:27 2013 -0700
----------------------------------------------------------------------
.../META-INF/modules/t5/core/console.coffee | 14 ++++++++++++++
1 file changed, 14 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2ce0b5a1/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
index 4db2ac5..f5ebb69 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
@@ -126,6 +126,20 @@ define ["./dom", "underscore"],
# and/or Selenium, it is very useful to present debugging data right on the page.
window.t5console = exports
+ requirejs.onError = (err) ->
+
+ message = "RequireJS error: #{err.requireType}"
+
+ if err.message
+ message += """: #{err.message}"""
+
+ if err.requireType
+ message += """, modules #{err.requireModules.join(", ")}"""
+
+
+ exports.error message
+
+
# Return the exports; we keep a reference to it, so we can see exports.DURATION, even
# if some other module imports this one and modifies that property.
return exports
\ No newline at end of file
[8/8] git commit: Delay field focus 1/8th second to allow for other
initializations
Posted by hl...@apache.org.
Delay field focus 1/8th second to allow for other initializations
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/1701e3b3
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/1701e3b3
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/1701e3b3
Branch: refs/heads/master
Commit: 1701e3b365190b3b7ea3f48f0f1a5b5cc1abc124
Parents: bc47f5d
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 11:29:33 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 11:29:33 2013 -0700
----------------------------------------------------------------------
.../coffeescript/META-INF/modules/t5/core/pageinit.coffee | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/1701e3b3/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
index bf42856..89d9fbf 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
@@ -172,10 +172,15 @@ define ["underscore", "./console", "./dom", "./events"],
console.debug "Evaluating: #{js}"
eval js
+ # Triggers the focus event on the field, if the field exist. Focus occurs delayed 1/8th of a
+ # second, which helps ensure that other initializions on the page are in place.
+ #
+ # * fieldId - element id of field to focus on
focus: (fieldId) ->
field = dom fieldId
- field && field.focus()
+ if field
+ _.delay (-> field.focus()), 125
# Passed the response from an Ajax request, when the request is successful.
# This is used for any request that attaches partial-page-render data to the main JSON object
[4/8] git commit: Add ElementWrapper.children()
Posted by hl...@apache.org.
Add ElementWrapper.children()
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/36de8382
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/36de8382
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/36de8382
Branch: refs/heads/master
Commit: 36de83828271b6f154e1c461d3a7729a522c2af6
Parents: 2ce0b5a
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 09:35:38 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 09:35:38 2013 -0700
----------------------------------------------------------------------
.../org/apache/tapestry5/t5-core-dom.coffee | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/36de8382/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
index b7e9ab8..4fa9ca4 100644
--- a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
+++ b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
@@ -445,14 +445,12 @@ define ["underscore", "./utils", "./events", "jquery"],
#if jquery
matches = @$.find selector
- return [] if matches.length is 0
-
- for i in [0..(matches.length - 1)]
+ for i in [0...matches.length]
new ElementWrapper matches.eq i
#elseif prototype
matches = @element.select selector
- _.map matches, (e) -> new ElementWrapper e
+ new ElementWrapper(e) for e in matches
#endif
# Find the first container element that matches the selector (wrapped as an ElementWrapper),
@@ -504,6 +502,18 @@ define ["underscore", "./utils", "./events", "jquery"],
#endif
new ElementWrapper parent
+ # Returns an array of all the immediate child elements of this element, as ElementWrappers.
+ children: ->
+#if jquery
+ children = @$.children()
+
+ for i in [0...matches.length]
+ new ElementWrapper children.eq i
+
+#elseif prototype
+ new ElementWrapper(e) for e in @element.childElements()
+#endif
+
# Returns true if this element is visible, false otherwise. This does not check to see if all containers of the
# element are visible.
visible: ->
[5/8] git commit: Add a text field for dynamic filtering of the
floating console messages
Posted by hl...@apache.org.
Add a text field for dynamic filtering of the floating console messages
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/01cfeb1d
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/01cfeb1d
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/01cfeb1d
Branch: refs/heads/master
Commit: 01cfeb1d188ffb775abc4b6b04f39e39770ba71e
Parents: 36de838
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 09:36:17 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 09:36:17 2013 -0700
----------------------------------------------------------------------
.../META-INF/modules/t5/core/console.coffee | 62 ++++++++++++++++----
1 file changed, 49 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/01cfeb1d/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
index f5ebb69..fcc6bf8 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
@@ -20,7 +20,23 @@ define ["./dom", "underscore"],
nativeConsole = {}
floatingConsole = null
- alertContainer = null
+ messages = null
+
+ noFilter = -> true
+
+ filter = noFilter
+
+ updateFilter = (text) ->
+ if text is ""
+ filter = noFilter
+ return
+
+ text = text.toLowerCase()
+
+ filter = (e) ->
+ e.element.innerText.toLowerCase().indexOf(text) >= 0
+
+ return
forceFloating = (dom.body.attribute "data-floating-console") == "true"
@@ -41,25 +57,28 @@ define ["./dom", "underscore"],
class: "tapestry-console",
"""
<div class="message-container"></div>
- <button data-action="clear" class="btn btn-mini"><i class="icon-remove"></i> Clear Console</button>
- <button data-action="enable" class="btn btn-mini" disabled="true"><i class="icon-play"></i> Enable Console</button>
- <button data-action="disable" class="btn btn-mini"><i class="icon-pause"></i> Disable Console</button>
+ <div class="row-fluid">
+ <button data-action="clear" class="btn btn-mini"><i class="icon-remove"></i> Clear Console</button>
+ <button data-action="enable" class="btn btn-mini" disabled="true"><i class="icon-play"></i> Enable Console</button>
+ <button data-action="disable" class="btn btn-mini"><i class="icon-pause"></i> Disable Console</button>
+ <input class="search-query input-xlarge" size="40" placeholder="Filter console content">
+ </div>
"""
dom.body.prepend floatingConsole
- alertContainer = floatingConsole.findFirst ".message-container"
+ messages = floatingConsole.findFirst ".message-container"
floatingConsole.on "click", "[data-action=clear]", ->
floatingConsole.hide()
- alertContainer.update ""
+ messages.update ""
floatingConsole.on "click", "[data-action=disable]", ->
@attribute "disabled", true
floatingConsole.findFirst("[data-action=enable]").attribute "disabled", false
- alertContainer.hide()
+ messages.hide()
return false
@@ -68,19 +87,36 @@ define ["./dom", "underscore"],
@attribute "disabled", true
floatingConsole.findFirst("[data-action=disable]").attribute "disabled", false
- alertContainer.show()
+ messages.show()
return false
- alertContainer.append """
- <div class="#{className}">#{_.escape message}</div>
- """
+ floatingConsole.on "change keyup", ".search-query", ->
+ updateFilter @value()
+
+ for e in messages.children()
+ visible = filter e
+
+ e[if visible then "show" else "hide"]()
+
+ return false
+
+ div = dom.create
+ class: className,
+ _.escape message
+
+ # Should really filter on original message, not escaped.
+
+ unless filter div
+ div.hide()
+
+ messages.append div
- # Make sure the console is visible, even if disabled.
+ # Make sure the console is visible, even if disabled (and even if the new content is hidden).
floatingConsole.show()
# A slightly clumsy way to ensure that the container is scrolled to the bottom.
- _.delay -> alertContainer.element.scrollTop = alertContainer.element.scrollHeight
+ _.delay -> messages.element.scrollTop = messages.element.scrollHeight
level = (className, consolefn) ->
(message) ->
[4/8] git commit: Add ElementWrapper.children()
Posted by hl...@apache.org.
Add ElementWrapper.children()
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/36de8382
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/36de8382
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/36de8382
Branch: refs/heads/master
Commit: 36de83828271b6f154e1c461d3a7729a522c2af6
Parents: 2ce0b5a
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 09:35:38 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 09:35:38 2013 -0700
----------------------------------------------------------------------
.../org/apache/tapestry5/t5-core-dom.coffee | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/36de8382/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
index b7e9ab8..4fa9ca4 100644
--- a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
+++ b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
@@ -445,14 +445,12 @@ define ["underscore", "./utils", "./events", "jquery"],
#if jquery
matches = @$.find selector
- return [] if matches.length is 0
-
- for i in [0..(matches.length - 1)]
+ for i in [0...matches.length]
new ElementWrapper matches.eq i
#elseif prototype
matches = @element.select selector
- _.map matches, (e) -> new ElementWrapper e
+ new ElementWrapper(e) for e in matches
#endif
# Find the first container element that matches the selector (wrapped as an ElementWrapper),
@@ -504,6 +502,18 @@ define ["underscore", "./utils", "./events", "jquery"],
#endif
new ElementWrapper parent
+ # Returns an array of all the immediate child elements of this element, as ElementWrappers.
+ children: ->
+#if jquery
+ children = @$.children()
+
+ for i in [0...matches.length]
+ new ElementWrapper children.eq i
+
+#elseif prototype
+ new ElementWrapper(e) for e in @element.childElements()
+#endif
+
# Returns true if this element is visible, false otherwise. This does not check to see if all containers of the
# element are visible.
visible: ->
[6/8] git commit: Roll version number forward to 5.4-alpha-14
Posted by hl...@apache.org.
Roll version number forward to 5.4-alpha-14
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/f649276c
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/f649276c
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/f649276c
Branch: refs/heads/master
Commit: f649276c93b6f8fd6c3bbc0082c5c2a809b1453c
Parents: 01cfeb1
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 09:45:10 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 09:45:10 2013 -0700
----------------------------------------------------------------------
build.gradle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/f649276c/build.gradle
----------------------------------------------------------------------
diff --git a/build.gradle b/build.gradle
index 13dd9e3..4b330a8 100755
--- a/build.gradle
+++ b/build.gradle
@@ -36,7 +36,7 @@ project.version = tapestryVersion()
def tapestryVersion() {
def major = "5.4"
- def minor = "-alpha-13"
+ def minor = "-alpha-14"
// When building on the CI server, make sure -SNAPSHOT is appended, as it is a nightly build.
// When building normally, or for a release, no suffix is desired.
[8/8] git commit: Delay field focus 1/8th second to allow for other
initializations
Posted by hl...@apache.org.
Delay field focus 1/8th second to allow for other initializations
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/1701e3b3
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/1701e3b3
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/1701e3b3
Branch: refs/heads/master
Commit: 1701e3b365190b3b7ea3f48f0f1a5b5cc1abc124
Parents: bc47f5d
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 11:29:33 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 11:29:33 2013 -0700
----------------------------------------------------------------------
.../coffeescript/META-INF/modules/t5/core/pageinit.coffee | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/1701e3b3/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
index bf42856..89d9fbf 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/pageinit.coffee
@@ -172,10 +172,15 @@ define ["underscore", "./console", "./dom", "./events"],
console.debug "Evaluating: #{js}"
eval js
+ # Triggers the focus event on the field, if the field exist. Focus occurs delayed 1/8th of a
+ # second, which helps ensure that other initializions on the page are in place.
+ #
+ # * fieldId - element id of field to focus on
focus: (fieldId) ->
field = dom fieldId
- field && field.focus()
+ if field
+ _.delay (-> field.focus()), 125
# Passed the response from an Ajax request, when the request is successful.
# This is used for any request that attaches partial-page-render data to the main JSON object
[5/8] git commit: Add a text field for dynamic filtering of the
floating console messages
Posted by hl...@apache.org.
Add a text field for dynamic filtering of the floating console messages
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/01cfeb1d
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/01cfeb1d
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/01cfeb1d
Branch: refs/heads/master
Commit: 01cfeb1d188ffb775abc4b6b04f39e39770ba71e
Parents: 36de838
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 09:36:17 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 09:36:17 2013 -0700
----------------------------------------------------------------------
.../META-INF/modules/t5/core/console.coffee | 62 ++++++++++++++++----
1 file changed, 49 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/01cfeb1d/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
index f5ebb69..fcc6bf8 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
@@ -20,7 +20,23 @@ define ["./dom", "underscore"],
nativeConsole = {}
floatingConsole = null
- alertContainer = null
+ messages = null
+
+ noFilter = -> true
+
+ filter = noFilter
+
+ updateFilter = (text) ->
+ if text is ""
+ filter = noFilter
+ return
+
+ text = text.toLowerCase()
+
+ filter = (e) ->
+ e.element.innerText.toLowerCase().indexOf(text) >= 0
+
+ return
forceFloating = (dom.body.attribute "data-floating-console") == "true"
@@ -41,25 +57,28 @@ define ["./dom", "underscore"],
class: "tapestry-console",
"""
<div class="message-container"></div>
- <button data-action="clear" class="btn btn-mini"><i class="icon-remove"></i> Clear Console</button>
- <button data-action="enable" class="btn btn-mini" disabled="true"><i class="icon-play"></i> Enable Console</button>
- <button data-action="disable" class="btn btn-mini"><i class="icon-pause"></i> Disable Console</button>
+ <div class="row-fluid">
+ <button data-action="clear" class="btn btn-mini"><i class="icon-remove"></i> Clear Console</button>
+ <button data-action="enable" class="btn btn-mini" disabled="true"><i class="icon-play"></i> Enable Console</button>
+ <button data-action="disable" class="btn btn-mini"><i class="icon-pause"></i> Disable Console</button>
+ <input class="search-query input-xlarge" size="40" placeholder="Filter console content">
+ </div>
"""
dom.body.prepend floatingConsole
- alertContainer = floatingConsole.findFirst ".message-container"
+ messages = floatingConsole.findFirst ".message-container"
floatingConsole.on "click", "[data-action=clear]", ->
floatingConsole.hide()
- alertContainer.update ""
+ messages.update ""
floatingConsole.on "click", "[data-action=disable]", ->
@attribute "disabled", true
floatingConsole.findFirst("[data-action=enable]").attribute "disabled", false
- alertContainer.hide()
+ messages.hide()
return false
@@ -68,19 +87,36 @@ define ["./dom", "underscore"],
@attribute "disabled", true
floatingConsole.findFirst("[data-action=disable]").attribute "disabled", false
- alertContainer.show()
+ messages.show()
return false
- alertContainer.append """
- <div class="#{className}">#{_.escape message}</div>
- """
+ floatingConsole.on "change keyup", ".search-query", ->
+ updateFilter @value()
+
+ for e in messages.children()
+ visible = filter e
+
+ e[if visible then "show" else "hide"]()
+
+ return false
+
+ div = dom.create
+ class: className,
+ _.escape message
+
+ # Should really filter on original message, not escaped.
+
+ unless filter div
+ div.hide()
+
+ messages.append div
- # Make sure the console is visible, even if disabled.
+ # Make sure the console is visible, even if disabled (and even if the new content is hidden).
floatingConsole.show()
# A slightly clumsy way to ensure that the container is scrolled to the bottom.
- _.delay -> alertContainer.element.scrollTop = alertContainer.element.scrollHeight
+ _.delay -> messages.element.scrollTop = messages.element.scrollHeight
level = (className, consolefn) ->
(message) ->
[2/8] git commit: Improve the floating console: - Fixed background in
"Tapestry Green" - Round the top corners - Use monospaced text (not Alerts) -
Keep history until manually cleared - Limit height to 200px
Posted by hl...@apache.org.
Improve the floating console:
- Fixed background in "Tapestry Green"
- Round the top corners
- Use monospaced text (not Alerts)
- Keep history until manually cleared
- Limit height to 200px
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/2ec37ad4
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/2ec37ad4
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/2ec37ad4
Branch: refs/heads/master
Commit: 2ec37ad4bdf77ba209d8f5f44ec1e26eda245574
Parents: cddab13
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 08:48:19 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 08:48:19 2013 -0700
----------------------------------------------------------------------
.../META-INF/modules/t5/core/console.coffee | 58 +++++---------------
.../assets/tapestry5/tapestry-console.css | 40 ++++++++------
2 files changed, 35 insertions(+), 63 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2ec37ad4/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
index 4eaf6b6..4db2ac5 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
@@ -24,14 +24,6 @@ define ["./dom", "underscore"],
forceFloating = (dom.body.attribute "data-floating-console") == "true"
- FADE_DURATION = 0.25
-
- # module exports are mutable; someone else could
- # require this module to change the default DURATION
- exports =
- # Default duration for floating console in seconds.
- DURATION: 10
-
try
# FireFox will throw an exception if you even access the console object and it does
# not exist. Wow!
@@ -48,8 +40,7 @@ define ["./dom", "underscore"],
floatingConsole = dom.create
class: "tapestry-console",
"""
- <div class="console-backdrop"></div>
- <div class="alert-container"></div>
+ <div class="message-container"></div>
<button data-action="clear" class="btn btn-mini"><i class="icon-remove"></i> Clear Console</button>
<button data-action="enable" class="btn btn-mini" disabled="true"><i class="icon-play"></i> Enable Console</button>
<button data-action="disable" class="btn btn-mini"><i class="icon-pause"></i> Disable Console</button>
@@ -57,7 +48,7 @@ define ["./dom", "underscore"],
dom.body.prepend floatingConsole
- alertContainer = floatingConsole.findFirst ".alert-container"
+ alertContainer = floatingConsole.findFirst ".message-container"
floatingConsole.on "click", "[data-action=clear]", ->
floatingConsole.hide()
@@ -81,39 +72,16 @@ define ["./dom", "underscore"],
return false
- div = dom.create
- class: "alert #{className}"
- """
- <button class="close">×</button>
- #{_.escape message}
+ alertContainer.append """
+ <div class="#{className}">#{_.escape message}</div>
"""
+ # Make sure the console is visible, even if disabled.
floatingConsole.show()
- alertContainer.append div.hide().fadeIn FADE_DURATION
# A slightly clumsy way to ensure that the container is scrolled to the bottom.
_.delay -> alertContainer.element.scrollTop = alertContainer.element.scrollHeight
- animating = false
-
- runFadeout = ->
- return if animating
-
- animating = true
-
- div.fadeOut FADE_DURATION, ->
- dom.withReflowEventsDisabled ->
- # Remove if not already removed
- div.remove() if div.parent()
-
- # Hide the console after the last one is removed.
- unless floatingConsole.findFirst(".alert")
- floatingConsole.hide()
-
- window.setTimeout runFadeout, exports.DURATION * 1000
-
- div.on "click", -> runFadeout()
-
level = (className, consolefn) ->
(message) ->
# consolefn may be null if there's no console; under IE it may be non-null, but not a function.
@@ -137,23 +105,23 @@ define ["./dom", "underscore"],
return
+ exports =
+ info: level "info", nativeConsole.info
+ warn: level "warn", nativeConsole.warn
+ error: level "error", nativeConsole.error
- # Determine whether debug is enabled by checking for the necessary attribute (which is missing
- # in production mode).
- exports.debugEnabled = (document.documentElement.getAttribute "data-debug-enabled")?
+ # Determine whether debug is enabled by checking for the necessary attribute (which is missing
+ # in production mode).
+ debugEnabled: (document.documentElement.getAttribute "data-debug-enabled")?
# When debugging is not enabled, then the debug function becomes a no-op.
exports.debug =
if exports.debugEnabled
# If native console available, go for it. IE doesn't have debug, so we use log instead.
- level "", (nativeConsole.debug or nativeConsole.log)
+ level "debug", (nativeConsole.debug or nativeConsole.log)
else
->
- exports.info = level "alert-info", nativeConsole.info
- exports.warn = level "", nativeConsole.warn
- exports.error = level "alert-error", nativeConsole.error
-
# This is also an aid to debugging; it allows arbitrary scripts to present on the console; when using Geb
# and/or Selenium, it is very useful to present debugging data right on the page.
window.t5console = exports
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2ec37ad4/tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry-console.css
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry-console.css b/tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry-console.css
index 55eb257..de98d34 100644
--- a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry-console.css
+++ b/tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry-console.css
@@ -5,28 +5,32 @@
bottom: 0px;
left: 0px;
right: 0px;
- border-radius: 4px;
padding: 5px;
+ border-top-left-radius: 4px;
+ border-top-right-radius: 4px;
+ background-color: #8DBA4A;
+
+}
+
+.tapestry-console > .message-container {
+ max-height: 200px;
+ overflow-y: scroll;
+ font-size: 14px;
+ font-family: monospace;
+ background-color: white;
+ margin-bottom: 2px;
+ padding-left: 2px;
}
-.tapestry-console > .console-backdrop {
- position: absolute;
- background-color: black;
- opacity: .5;
- top: 0;
- left: 0;
- bottom: 0;
- right: 0;
- z-index: -1;
+.tapestry-console > .message-container > .debug {
+ color: blue;
}
-.tapestry-console > .alert-container {
- max-height: 300px;
- overflow-x: auto;
+.tapestry-console > .message-container > .warn {
+ color: #c09853;
}
-/** Unlike a normal alert, a console message can be dismissed by a click anywhere. */
-.tapestry-console .alert{
- cursor: pointer;
- margin-bottom: 5px;
-}
\ No newline at end of file
+.tapestry-console > .message-container > .error {
+ color: #b94a48;
+ font-weight: bold;
+}
[2/8] git commit: Improve the floating console: - Fixed background in
"Tapestry Green" - Round the top corners - Use monospaced text (not Alerts) -
Keep history until manually cleared - Limit height to 200px
Posted by hl...@apache.org.
Improve the floating console:
- Fixed background in "Tapestry Green"
- Round the top corners
- Use monospaced text (not Alerts)
- Keep history until manually cleared
- Limit height to 200px
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/2ec37ad4
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/2ec37ad4
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/2ec37ad4
Branch: refs/heads/master
Commit: 2ec37ad4bdf77ba209d8f5f44ec1e26eda245574
Parents: cddab13
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 08:48:19 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 08:48:19 2013 -0700
----------------------------------------------------------------------
.../META-INF/modules/t5/core/console.coffee | 58 +++++---------------
.../assets/tapestry5/tapestry-console.css | 40 ++++++++------
2 files changed, 35 insertions(+), 63 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2ec37ad4/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
index 4eaf6b6..4db2ac5 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
@@ -24,14 +24,6 @@ define ["./dom", "underscore"],
forceFloating = (dom.body.attribute "data-floating-console") == "true"
- FADE_DURATION = 0.25
-
- # module exports are mutable; someone else could
- # require this module to change the default DURATION
- exports =
- # Default duration for floating console in seconds.
- DURATION: 10
-
try
# FireFox will throw an exception if you even access the console object and it does
# not exist. Wow!
@@ -48,8 +40,7 @@ define ["./dom", "underscore"],
floatingConsole = dom.create
class: "tapestry-console",
"""
- <div class="console-backdrop"></div>
- <div class="alert-container"></div>
+ <div class="message-container"></div>
<button data-action="clear" class="btn btn-mini"><i class="icon-remove"></i> Clear Console</button>
<button data-action="enable" class="btn btn-mini" disabled="true"><i class="icon-play"></i> Enable Console</button>
<button data-action="disable" class="btn btn-mini"><i class="icon-pause"></i> Disable Console</button>
@@ -57,7 +48,7 @@ define ["./dom", "underscore"],
dom.body.prepend floatingConsole
- alertContainer = floatingConsole.findFirst ".alert-container"
+ alertContainer = floatingConsole.findFirst ".message-container"
floatingConsole.on "click", "[data-action=clear]", ->
floatingConsole.hide()
@@ -81,39 +72,16 @@ define ["./dom", "underscore"],
return false
- div = dom.create
- class: "alert #{className}"
- """
- <button class="close">×</button>
- #{_.escape message}
+ alertContainer.append """
+ <div class="#{className}">#{_.escape message}</div>
"""
+ # Make sure the console is visible, even if disabled.
floatingConsole.show()
- alertContainer.append div.hide().fadeIn FADE_DURATION
# A slightly clumsy way to ensure that the container is scrolled to the bottom.
_.delay -> alertContainer.element.scrollTop = alertContainer.element.scrollHeight
- animating = false
-
- runFadeout = ->
- return if animating
-
- animating = true
-
- div.fadeOut FADE_DURATION, ->
- dom.withReflowEventsDisabled ->
- # Remove if not already removed
- div.remove() if div.parent()
-
- # Hide the console after the last one is removed.
- unless floatingConsole.findFirst(".alert")
- floatingConsole.hide()
-
- window.setTimeout runFadeout, exports.DURATION * 1000
-
- div.on "click", -> runFadeout()
-
level = (className, consolefn) ->
(message) ->
# consolefn may be null if there's no console; under IE it may be non-null, but not a function.
@@ -137,23 +105,23 @@ define ["./dom", "underscore"],
return
+ exports =
+ info: level "info", nativeConsole.info
+ warn: level "warn", nativeConsole.warn
+ error: level "error", nativeConsole.error
- # Determine whether debug is enabled by checking for the necessary attribute (which is missing
- # in production mode).
- exports.debugEnabled = (document.documentElement.getAttribute "data-debug-enabled")?
+ # Determine whether debug is enabled by checking for the necessary attribute (which is missing
+ # in production mode).
+ debugEnabled: (document.documentElement.getAttribute "data-debug-enabled")?
# When debugging is not enabled, then the debug function becomes a no-op.
exports.debug =
if exports.debugEnabled
# If native console available, go for it. IE doesn't have debug, so we use log instead.
- level "", (nativeConsole.debug or nativeConsole.log)
+ level "debug", (nativeConsole.debug or nativeConsole.log)
else
->
- exports.info = level "alert-info", nativeConsole.info
- exports.warn = level "", nativeConsole.warn
- exports.error = level "alert-error", nativeConsole.error
-
# This is also an aid to debugging; it allows arbitrary scripts to present on the console; when using Geb
# and/or Selenium, it is very useful to present debugging data right on the page.
window.t5console = exports
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2ec37ad4/tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry-console.css
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry-console.css b/tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry-console.css
index 55eb257..de98d34 100644
--- a/tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry-console.css
+++ b/tapestry-core/src/main/resources/META-INF/assets/tapestry5/tapestry-console.css
@@ -5,28 +5,32 @@
bottom: 0px;
left: 0px;
right: 0px;
- border-radius: 4px;
padding: 5px;
+ border-top-left-radius: 4px;
+ border-top-right-radius: 4px;
+ background-color: #8DBA4A;
+
+}
+
+.tapestry-console > .message-container {
+ max-height: 200px;
+ overflow-y: scroll;
+ font-size: 14px;
+ font-family: monospace;
+ background-color: white;
+ margin-bottom: 2px;
+ padding-left: 2px;
}
-.tapestry-console > .console-backdrop {
- position: absolute;
- background-color: black;
- opacity: .5;
- top: 0;
- left: 0;
- bottom: 0;
- right: 0;
- z-index: -1;
+.tapestry-console > .message-container > .debug {
+ color: blue;
}
-.tapestry-console > .alert-container {
- max-height: 300px;
- overflow-x: auto;
+.tapestry-console > .message-container > .warn {
+ color: #c09853;
}
-/** Unlike a normal alert, a console message can be dismissed by a click anywhere. */
-.tapestry-console .alert{
- cursor: pointer;
- margin-bottom: 5px;
-}
\ No newline at end of file
+.tapestry-console > .message-container > .error {
+ color: #b94a48;
+ font-weight: bold;
+}
[3/8] git commit: Hook requirejs.onError() to present RequireJS
errors in the floating console (if enabled)
Posted by hl...@apache.org.
Hook requirejs.onError() to present RequireJS errors in the floating console (if enabled)
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/2ce0b5a1
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/2ce0b5a1
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/2ce0b5a1
Branch: refs/heads/master
Commit: 2ce0b5a19fcdd4569af5c8b2ebc97d4e8f14803a
Parents: 2ec37ad
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 08:57:27 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 08:57:27 2013 -0700
----------------------------------------------------------------------
.../META-INF/modules/t5/core/console.coffee | 14 ++++++++++++++
1 file changed, 14 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/2ce0b5a1/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
index 4db2ac5..f5ebb69 100644
--- a/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
+++ b/tapestry-core/src/main/coffeescript/META-INF/modules/t5/core/console.coffee
@@ -126,6 +126,20 @@ define ["./dom", "underscore"],
# and/or Selenium, it is very useful to present debugging data right on the page.
window.t5console = exports
+ requirejs.onError = (err) ->
+
+ message = "RequireJS error: #{err.requireType}"
+
+ if err.message
+ message += """: #{err.message}"""
+
+ if err.requireType
+ message += """, modules #{err.requireModules.join(", ")}"""
+
+
+ exports.error message
+
+
# Return the exports; we keep a reference to it, so we can see exports.DURATION, even
# if some other module imports this one and modifies that property.
return exports
\ No newline at end of file
[7/8] git commit: Correct the jQuery version of
ElementWrapper.children()
Posted by hl...@apache.org.
Correct the jQuery version of ElementWrapper.children()
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/bc47f5d8
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/bc47f5d8
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/bc47f5d8
Branch: refs/heads/master
Commit: bc47f5d8b67a2f1e7736a62131329a0e304890a8
Parents: f649276
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 10:04:23 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 10:04:23 2013 -0700
----------------------------------------------------------------------
.../org/apache/tapestry5/t5-core-dom.coffee | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/bc47f5d8/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
index 4fa9ca4..eac41fd 100644
--- a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
+++ b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
@@ -507,7 +507,7 @@ define ["underscore", "./utils", "./events", "jquery"],
#if jquery
children = @$.children()
- for i in [0...matches.length]
+ for i in [0...children.length]
new ElementWrapper children.eq i
#elseif prototype
[7/8] git commit: Correct the jQuery version of
ElementWrapper.children()
Posted by hl...@apache.org.
Correct the jQuery version of ElementWrapper.children()
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/bc47f5d8
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/bc47f5d8
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/bc47f5d8
Branch: refs/heads/master
Commit: bc47f5d8b67a2f1e7736a62131329a0e304890a8
Parents: f649276
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 10:04:23 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 10:04:23 2013 -0700
----------------------------------------------------------------------
.../org/apache/tapestry5/t5-core-dom.coffee | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/bc47f5d8/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
----------------------------------------------------------------------
diff --git a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
index 4fa9ca4..eac41fd 100644
--- a/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
+++ b/tapestry-core/src/main/preprocessed-coffeescript/org/apache/tapestry5/t5-core-dom.coffee
@@ -507,7 +507,7 @@ define ["underscore", "./utils", "./events", "jquery"],
#if jquery
children = @$.children()
- for i in [0...matches.length]
+ for i in [0...children.length]
new ElementWrapper children.eq i
#elseif prototype
[6/8] git commit: Roll version number forward to 5.4-alpha-14
Posted by hl...@apache.org.
Roll version number forward to 5.4-alpha-14
Project: http://git-wip-us.apache.org/repos/asf/tapestry-5/repo
Commit: http://git-wip-us.apache.org/repos/asf/tapestry-5/commit/f649276c
Tree: http://git-wip-us.apache.org/repos/asf/tapestry-5/tree/f649276c
Diff: http://git-wip-us.apache.org/repos/asf/tapestry-5/diff/f649276c
Branch: refs/heads/master
Commit: f649276c93b6f8fd6c3bbc0082c5c2a809b1453c
Parents: 01cfeb1
Author: Howard M. Lewis Ship <hl...@apache.org>
Authored: Mon Jul 22 09:45:10 2013 -0700
Committer: Howard M. Lewis Ship <hl...@apache.org>
Committed: Mon Jul 22 09:45:10 2013 -0700
----------------------------------------------------------------------
build.gradle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tapestry-5/blob/f649276c/build.gradle
----------------------------------------------------------------------
diff --git a/build.gradle b/build.gradle
index 13dd9e3..4b330a8 100755
--- a/build.gradle
+++ b/build.gradle
@@ -36,7 +36,7 @@ project.version = tapestryVersion()
def tapestryVersion() {
def major = "5.4"
- def minor = "-alpha-13"
+ def minor = "-alpha-14"
// When building on the CI server, make sure -SNAPSHOT is appended, as it is a nightly build.
// When building normally, or for a release, no suffix is desired.