You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/18 08:22:05 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #22258: Update Oracle SQL XMLCOLATTVAL function parse
Qianyi951015 opened a new pull request, #22258:
URL: https://github.com/apache/shardingsphere/pull/22258
Fixes #22254.
Ref: https://docs.oracle.com/en/database/oracle/oracle-database/12.2/sqlrf/XMLCOLATTVAL.html#GUID-AE3B6441-74D8-4033-900B-A578A79E5F0A
<img width="710" alt="image" src="https://user-images.githubusercontent.com/57847965/202654927-bd149b83-f1f8-4974-bb06-9ca79692fb99.png">
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22258: Update Oracle SQL XMLCOLATTVAL function parse
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #22258:
URL: https://github.com/apache/shardingsphere/pull/22258#discussion_r1026185477
##########
sql-parser/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4:
##########
@@ -1616,8 +1616,13 @@ datetimeExpr
xmlFunction
: xmlAggFunction
+ | xmlColattvalFunction
;
xmlAggFunction
: XMLAGG LP_ expr orderByClause? RP_
;
+
+xmlColattvalFunction
+ :XMLCOLATTVAL LP_ expr (AS (alias | EVALNAME expr))? (COMMA_ expr (AS (alias | EVALNAME expr))?)* RP_
Review Comment:
Missed a white space here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #22258: Update Oracle SQL XMLCOLATTVAL function parse
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22258:
URL: https://github.com/apache/shardingsphere/pull/22258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org