[GitHub] [zookeeper] dineshappavoo commented on a change in pull request #1025: [ZOOKEEPER-3471] Fix potential lock unavailable due to dangling ephemeral nodes left during local session upgrading

[GitBox <gi...@apache.org>]

dineshappavoo commented on a change in pull request #1025: [ZOOKEEPER-3471] Fix potential lock unavailable due to dangling ephemeral nodes left during local session upgrading
URL: https://github.com/apache/zookeeper/pull/1025#discussion_r310332083
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
 ##########
 @@ -992,6 +990,7 @@ public void submitRequestNow(Request si) {
             touch(si.cnxn);
             boolean validpacket = Request.isValid(si.type);
             if (validpacket) {
+                setLocalSessionFlag(si);
 
 Review comment:
   I might be missing some info here (Please correct me if I am). So this happening only for requests going through RequestThrottler? And not the requests going through RequestProcessor? (Since this `submitRequestNow` function is being called only in RequestThrottler)
   Appreciate if you could explain little bit more. Thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services