You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/05/02 13:52:14 UTC

[GitHub] [submarine] pingsutw commented on a diff in pull request #943: SUBMARINE-1235. Display test coverage in PR check progress

pingsutw commented on code in PR #943:
URL: https://github.com/apache/submarine/pull/943#discussion_r862864042


##########
.github/workflows/master.yml:
##########
@@ -556,9 +556,9 @@ jobs:
         run: |
           yarn add prettier@^2.6.2
           yarn checkformat
-  sonarcloud:
+  sonarcloud-and-codecov:
     if: github.repository == 'apache/submarine' && github.event_name == 'push' && github.ref == 'refs/heads/master'

Review Comment:
   sorry, I forgot we only trigger sonarcloud on push. we should add a new job for `codecov` to trigger it in pull-request.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org