You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/12/07 01:23:51 UTC

[GitHub] [dolphinscheduler] zhuangchong commented on a change in pull request #7221: [Bug] [API] queryProcessDefinitionByCode bug

zhuangchong commented on a change in pull request #7221:
URL: https://github.com/apache/dolphinscheduler/pull/7221#discussion_r763556501



##########
File path: dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/TaskDefinitionLogMapper.xml
##########
@@ -47,6 +47,9 @@
                 and version = #{item.version})
             </foreach>
         </if>
+        <if test="taskDefinitions == null or taskDefinitions.size == 0">

Review comment:
       Judge taskDefinitions as a required parameter, please add it to the business layer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org