You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/11/27 15:06:06 UTC

[GitHub] bwsw commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account

bwsw commented on issue #3058: CLOUDSTACK-3049: update dynamic role for an account
URL: https://github.com/apache/cloudstack/pull/3058#issuecomment-442091377
 
 
   > Can you instead implement a cleaner approach, say create a new API?
   
   @rhtyd I considered both alternatives. My arguments for the current implementation:
   1. it adds smoke tests for updateAccount and as you can see before the implementation there wasn't testing for the method at all.
   2. updateAccount method was strangely implemented, e.g. one has to pass newname mandatory, this enhancement fixes the behavior as well.
   3. It's natural, I agree with Rafael, otherwise, it's true to implement every `update<Entity><Attribute>` separately and it will be hell without scoping.
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services