[GitHub] [beam] tvalentyn commented on a diff in pull request #24114: Update staging of Python wheels

[GitBox <gi...@apache.org>]

tvalentyn commented on code in PR #24114:
URL: https://github.com/apache/beam/pull/24114#discussion_r1020456265


##########
sdks/python/apache_beam/runners/portability/stager.py:
##########
@@ -897,10 +901,10 @@ def _create_beam_sdk(sdk_remote_location, temp_dir):
   def _download_pypi_sdk_package(
       temp_dir,
       fetch_binary=False,
-      language_version_tag='27',
+      language_version_tag='39',

Review Comment:
   doesn't matter here, but in general changing default values may be a risky change in case there are some callers that rely on older default.



##########
sdks/python/apache_beam/runners/portability/stager.py:
##########
@@ -935,7 +939,12 @@ def _download_pypi_sdk_package(
           '--platform',
           platform_tag
       ])
-      # Example wheel: apache_beam-2.4.0-cp27-cp27mu-manylinux1_x86_64.whl
+      # Example wheel: apache_beam-2.42.0-cp39-cp39-manylinux1_x86_64.whl
+      # Example wheel: with manylinux14 tag.
+      # apache_beam-2.43.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_

Review Comment:
   nit: you can move it on the same line for readability and disable linter on this line if necessary



##########
sdks/python/apache_beam/runners/portability/stager.py:
##########
@@ -935,7 +939,12 @@ def _download_pypi_sdk_package(
           '--platform',
           platform_tag
       ])
-      # Example wheel: apache_beam-2.4.0-cp27-cp27mu-manylinux1_x86_64.whl
+      # Example wheel: apache_beam-2.42.0-cp39-cp39-manylinux1_x86_64.whl

Review Comment:
   no longer need to mention the outdated case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org