[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4737: Change GET/POST request max length of VM user data to 4K/1M

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4737:
URL: https://github.com/apache/cloudstack/pull/4737#discussion_r584812314



##########
File path: api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
##########
@@ -80,8 +80,8 @@
 
     @Parameter(name = ApiConstants.USER_DATA,
                type = CommandType.STRING,
-               description = "an optional binary data that can be sent to the virtual machine upon a successful deployment. This binary data must be base64 encoded before adding it to the request. Using HTTP GET (via querystring), you can send up to 2KB of data after base64 encoding. Using HTTP POST(via POST body), you can send up to 32K of data after base64 encoding.",
-               length = 32768)
+               description = "an optional binary data that can be sent to the virtual machine upon a successful deployment. This binary data must be base64 encoded before adding it to the request. Using HTTP GET (via querystring), you can send up to 4KB of data after base64 encoding. Using HTTP POST(via POST body), you can send up to 1MB of data after base64 encoding.",

Review comment:
       this should include a remark like `if you increase the value of "vm.userdata.max.length"`, shouldn't it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org