You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "matthewgapp (via GitHub)" <gi...@apache.org> on 2023/09/27 15:00:48 UTC

[GitHub] [arrow-datafusion] matthewgapp commented on a diff in pull request #7638: mark appropriate window functions as nullable: false in logical plan

matthewgapp commented on code in PR #7638:
URL: https://github.com/apache/arrow-datafusion/pull/7638#discussion_r1338752948


##########
datafusion/sqllogictest/test_files/window.slt:
##########
@@ -3315,3 +3315,23 @@ SELECT
   window1 AS (ORDER BY C3)
   ORDER BY C3
   LIMIT 5
+
+# Create table with window functions that have nullable: false columns should result in correct schema during cross join

Review Comment:
   Note that as of arrow `47.0.0`, these tests will no longer fail because arrow no longer checks schema nullability. For more context, see https://github.com/apache/arrow-datafusion/issues/7636#issuecomment-1737225422. 
   
   To that end, I should introduce tests that explicitly check the logical schema for `nullable: false` when we expect it to be (e.g., for columns created via row_number(), rank(), etc). I'll get around to this tonight. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org