[jira] [Commented] (CB-11730) plugman miss the last file/folder when installing plugin on windows

["Yasuharu Seki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-11730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429996#comment-15429996 ] 

Yasuharu Seki commented on CB-11730:
------------------------------------

A quick solution would be here.
plugman/fetch.js(347)

filenames.splice(filenames.indexOf(relativeRootFolder),1);
->
var index = filenames.indexOf(relativeRootFolder);
if(0 < index){
	filenames.splice(index,1);
}

But probably, make strict folder name match on if clause at (333) is better than the solution above.

> plugman miss the last file/folder when installing plugin on windows
> -------------------------------------------------------------------
>
>                 Key: CB-11730
>                 URL: https://issues.apache.org/jira/browse/CB-11730
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>    Affects Versions: 6.0.0
>         Environment: Windows
> plugman --version
> 1.2.1
> cordova --version
> 6.3.1
>            Reporter: Yasuharu Seki
>            Priority: Trivial
>
> Steps to reproduce:
> - Create simple plugin
> $ plugman create --name SimplePlugin --plugin_id org.simple.plugin --plugin_version 1.0.0
> - Create cordova project it includes the name of plugin
> $ cordova create SimplePlugin_TestBed
> - Install the plugin into the created project
> $ cordova plugin add ../SimplePlugin
> -> Check the plugins/org.simple.plugin folder
>   Find www/ folder is missing.
> The reason is filenames.indexOf(relativeRootFolder) returns -1 when the target folder name cannot find in the plugin folder.
> The original code works good when the project is on the child folder.
> [plugin]/[project of plugin_testbed]
> But does not the project as sibling.
> [plugin]
> [project of plugin_testbed]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org