You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/05/01 16:57:59 UTC
[GitHub] [arrow-adbc] zeroshade opened a new pull request, #637: fix(go/adbc/driver/snowflake): some more cleanup
zeroshade opened a new pull request, #637:
URL: https://github.com/apache/arrow-adbc/pull/637
Fixes #631 and cleans up an issue with simultaneous testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #637: fix(go/adbc/driver/snowflake): some more cleanup
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #637:
URL: https://github.com/apache/arrow-adbc/pull/637#discussion_r1182068490
##########
go/adbc/validation/validation.go:
##########
@@ -65,6 +65,8 @@ type DriverQuirks interface {
// have the driver drop a table with the correct SQL syntax
DropTable(adbc.Connection, string) error
+ ExampleSchema() string
Review Comment:
Should we call this `DbSchema` for consistency and so that it's not confused with an Arrow schema?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm merged pull request #637: fix(go/adbc/driver/snowflake): some more cleanup
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #637:
URL: https://github.com/apache/arrow-adbc/pull/637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on a diff in pull request #637: fix(go/adbc/driver/snowflake): some more cleanup
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #637:
URL: https://github.com/apache/arrow-adbc/pull/637#discussion_r1182847545
##########
go/adbc/validation/validation.go:
##########
@@ -65,6 +65,8 @@ type DriverQuirks interface {
// have the driver drop a table with the correct SQL syntax
DropTable(adbc.Connection, string) error
+ ExampleSchema() string
Review Comment:
fair, that's a good point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org