[PATCH] "fix" recognition of APR 2.x

[Jeff Trawick <tr...@gmail.com>]

Check out trunk.  Check out APR trunk and APR-Util trunk into srclib/apr and
srclib/apr-util.  "./configure --with-included-apr".  See error messages
containing "apr-1-config" scroll by.

trunk/configure.in looks for apr-2-config, but it does so before srclib/apr
is configured, when apr-2-config doesn't exist (unless the user configures
srclib/apr first).

The attached patch checks the version after the configure.  It also attempts
to handle the APR_FIND_APR() path (untested).  On the APR-Util side, it
bases the apu-config path on the APR major version and tells APR_FIND_APU()
to find one that matches APR's major version (latter part untested).

I wouldn't be at all surprised if other folks are already using APR trunk
with httpd trunk daily and I've missed something basic, so comments
appreciated ;)

Re: [PATCH] "fix" recognition of APR 2.x

[Mladen Turk <mt...@apache.org>]

Jeff Trawick wrote:
> 
> I wouldn't be at all surprised if other folks are already using APR 
> trunk with httpd trunk daily and I've missed something basic, so 
> comments appreciated ;)
> 

Right, I hand-crafted this, so you have my +1

Anyhow, what about making some release apr-2 dependent
so we can use apr-2 API. Don't think it's very smart
to #ifdef the code.


Regards
-- 
^(TM)

Re: [PATCH] "fix" recognition of APR 2.x

[Jeff Trawick <tr...@gmail.com>]

On Mon, Mar 2, 2009 at 12:23 PM, Eric Covener <co...@gmail.com> wrote:

> On Mon, Mar 2, 2009 at 11:07 AM, Jeff Trawick <tr...@gmail.com> wrote:
> > (I'll commit before long unless somebody who has it working now with APR
> > trunk has a suggestion.)
>
> Just confirmed that my changes were dead code with a clean tree, so no
> squeak here.


thanks!

Re: [PATCH] "fix" recognition of APR 2.x

[Eric Covener <co...@gmail.com>]

On Mon, Mar 2, 2009 at 11:07 AM, Jeff Trawick <tr...@gmail.com> wrote:
> (I'll commit before long unless somebody who has it working now with APR
> trunk has a suggestion.)

Just confirmed that my changes were dead code with a clean tree, so no
squeak here.


-- 
Eric Covener
covener@gmail.com

Re: [PATCH] "fix" recognition of APR 2.x

[Jeff Trawick <tr...@gmail.com>]

On Mon, Mar 2, 2009 at 10:31 AM, William A. Rowe, Jr.
<wr...@rowe-clan.net>wrote:

> Jeff Trawick wrote:
>
>> Check out trunk.  Check out APR trunk and APR-Util trunk into srclib/apr
>> and srclib/apr-util.  "./configure --with-included-apr".  See error messages
>> containing "apr-1-config" scroll by.
>>
>
> Just so you are aware, list consensus has it that apr-util falls off
> of trunk and becomes part of apr.  So I'd suggest this is a temporary
> condition... fixing apr-util isn't really an interesting exercise ;-)


No concerns here...  The precious few new APR-Util lines in the patch will
get chopped off with the rest of that block when that happens.

(I'll commit before long unless somebody who has it working now with APR
trunk has a suggestion.)

Re: [PATCH] "fix" recognition of APR 2.x

[Branko Čibej <br...@xbc.nu>]

Mladen Turk wrote:
> William A. Rowe, Jr. wrote:
>>
>> If someone is shipping apr trunk, that's a big
>> mistake (theirs, not ours, we'll still ship the true apr 2.0 at some
>> point which will be grossly incompatible to such one-offs).
>>
>> Part of this is the desire by Paul to move the project to scons.  I'm
>> prepared to merge the autoconf, but it's a bit more than an evening
>> project to combine apr and apr-util.  His hope was that scons is ready.
>>
>
> Just one question ...
> What did you meant with "combine apr and apr-util" ?
> Does it mean apr-util will cease to exist and become part of apr,
> or you just commented the scons work

It's about apr and apr-util becoming a single library (in 2.x).

> (Just when I mastered autoconf, here comes the python.
>  What about something easier like lisp ;)

Oh really, scons should make things so much easier for everyone. Python
vs. m4 is a hands-down win any day. :)

If you want easier like lisp -- well now, i've heard of languages that
have even less structure and keywords to learn http://tinyurl.com/ying
or are more polite http://tinyurl.com/zuh32 ...

-- Brane
>
> Regards

Re: [PATCH] "fix" recognition of APR 2.x

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

Mladen Turk wrote:
> William A. Rowe, Jr. wrote:
>>
>> If someone is shipping apr trunk, that's a big
>> mistake (theirs, not ours, we'll still ship the true apr 2.0 at some
>> point which will be grossly incompatible to such one-offs).
>>
>> Part of this is the desire by Paul to move the project to scons.  I'm
>> prepared to merge the autoconf, but it's a bit more than an evening
>> project to combine apr and apr-util.  His hope was that scons is ready.
> 
> Just one question ...
> What did you meant with "combine apr and apr-util" ?
> Does it mean apr-util will cease to exist and become part of apr,

Yes; apr-util 'modules' all remain dynamic, apr-util folds into apr,
and something like ldap libs are never loaded unless the apr_ldap
API is initialized.  With explicit initialization of apr, there is
no problem or race conditions initializing these stubs.

> (Just when I mastered autoconf, here comes the python.
>  What about something easier like lisp ;)

Nah, time to use ADA as our conf language :)

Re: [PATCH] "fix" recognition of APR 2.x

[Mladen Turk <mt...@apache.org>]

William A. Rowe, Jr. wrote:
> 
> If someone is shipping apr trunk, that's a big
> mistake (theirs, not ours, we'll still ship the true apr 2.0 at some
> point which will be grossly incompatible to such one-offs).
> 
> Part of this is the desire by Paul to move the project to scons.  I'm
> prepared to merge the autoconf, but it's a bit more than an evening
> project to combine apr and apr-util.  His hope was that scons is ready.
>

Just one question ...
What did you meant with "combine apr and apr-util" ?
Does it mean apr-util will cease to exist and become part of apr,
or you just commented the scons work

(Just when I mastered autoconf, here comes the python.
  What about something easier like lisp ;)

Regards
-- 
^(TM)

Re: [PATCH] "fix" recognition of APR 2.x

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

Jeff Trawick wrote:
> Check out trunk.  Check out APR trunk and APR-Util trunk into srclib/apr 
> and srclib/apr-util.  "./configure --with-included-apr".  See error 
> messages containing "apr-1-config" scroll by.

Just so you are aware, list consensus has it that apr-util falls off
of trunk and becomes part of apr.  So I'd suggest this is a temporary
condition... fixing apr-util isn't really an interesting exercise ;-)

> I wouldn't be at all surprised if other folks are already using APR 
> trunk with httpd trunk daily and I've missed something basic, so 
> comments appreciated ;)

APR-trunk is not 2.0.0 yet, so that's a serious problem.  If other folks
are a handful of developers, it's not a problem, but it should push us to
make this transition.  If someone is shipping apr trunk, that's a big
mistake (theirs, not ours, we'll still ship the true apr 2.0 at some
point which will be grossly incompatible to such one-offs).

Part of this is the desire by Paul to move the project to scons.  I'm
prepared to merge the autoconf, but it's a bit more than an evening
project to combine apr and apr-util.  His hope was that scons is ready.