You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/09 18:27:37 UTC
[GitHub] [airflow] chenglongyan opened a new pull request, #24941: Migrate Google ads example to new design AIP-47
chenglongyan opened a new pull request, #24941:
URL: https://github.com/apache/airflow/pull/24941
related: #22447, #22430
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #24941: Migrate Google ads example to new design AIP-47
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #24941:
URL: https://github.com/apache/airflow/pull/24941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a diff in pull request #24941: Migrate Google ads example to new design AIP-47
Posted by GitBox <gi...@apache.org>.
turbaszek commented on code in PR #24941:
URL: https://github.com/apache/airflow/pull/24941#discussion_r917360983
##########
tests/system/providers/google/ads/example_ads.py:
##########
@@ -61,28 +68,58 @@
"metrics.all_conversions.value",
"metrics.cost_micros.value",
]
-
# [END howto_google_ads_env_variables]
with models.DAG(
- "example_google_ads",
- schedule_interval=None, # Override to match your needs
+ DAG_ID,
+ schedule_interval='@once',
Review Comment:
Is this change necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chenglongyan commented on a diff in pull request #24941: Migrate Google ads example to new design AIP-47
Posted by GitBox <gi...@apache.org>.
chenglongyan commented on code in PR #24941:
URL: https://github.com/apache/airflow/pull/24941#discussion_r917416402
##########
tests/system/providers/google/ads/example_ads.py:
##########
@@ -61,28 +68,58 @@
"metrics.all_conversions.value",
"metrics.cost_micros.value",
]
-
# [END howto_google_ads_env_variables]
with models.DAG(
- "example_google_ads",
- schedule_interval=None, # Override to match your needs
+ DAG_ID,
+ schedule_interval='@once',
Review Comment:
This is mentioned in the AIP-47 **Design details**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org