[jira] [Commented] (SPARK-6813) SparkR style guide

["Yu Ishikawa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590862#comment-14590862 ] 

Yu Ishikawa commented on SPARK-6813:
------------------------------------

Before discussing the details of coding style, let me confirm.
Should we consider the license of a lint software or not?

And in my opinion, merging the lint software to master branch is more important than making a perfect style guide. So first of all, we should create an almost perfect style guide and run unit tests on the official Jenkins to the style guide. If we think of a new idea for the style guide, we can add it later. 

> SparkR style guide
> ------------------
>
>                 Key: SPARK-6813
>                 URL: https://issues.apache.org/jira/browse/SPARK-6813
>             Project: Spark
>          Issue Type: New Feature
>          Components: SparkR
>            Reporter: Shivaram Venkataraman
>
> We should develop a SparkR style guide document based on the some of the guidelines we use and some of the best practices in R.
> Some examples of R style guide are:
> http://r-pkgs.had.co.nz/r.html#style 
> http://google-styleguide.googlecode.com/svn/trunk/google-r-style.html
> A related issue is to work on a automatic style checking tool. https://github.com/jimhester/lintr seems promising
> We could have a R style guide based on the one from google [1], and adjust some of them with the conversation in Spark:
> 1. Line Length: maximum 100 characters
> 2. no limit on function name (API should be similar as in other languages)
> 3. Allow S4 objects/methods



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org