You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/23 10:15:00 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1107: build: Don't need use $(DELIM) in include statement
xiaoxiang781216 opened a new pull request #1107:
URL: https://github.com/apache/incubator-nuttx/pull/1107
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #1107: build: Don't need use $(DELIM) in include statement
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #1107:
URL: https://github.com/apache/incubator-nuttx/pull/1107#issuecomment-633022194
@xiaoxiang781216 I have no context here and I am curious - are you killing off window support?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1107: build: Don't need use $(DELIM) in include statement
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #1107:
URL: https://github.com/apache/incubator-nuttx/pull/1107#issuecomment-633041687
> @xiaoxiang781216 I have no context here and I am curious - are you killing off window support?
No, Windows still support, $(DELIM) just need when we call Windows application in the Makefile rule but Makefile itself don't care we use '/' or '\' as I understand.
You can see from the above, the old codebase already use / to include Make.defs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1107: build: Don't need use $(DELIM) in include statement
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1107:
URL: https://github.com/apache/incubator-nuttx/pull/1107#issuecomment-633041687
> @xiaoxiang781216 I have no context here and I am curious - are you killing off window support?
No, Windows still support, $(DELIM) just need when we call Windows application in the Makefile rule but Makefile itself don't care we use '/' or '\' as I understand.
You can see from the above, the old already use / to include Make.defs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo merged pull request #1107: build: Don't need use $(DELIM) in include statement
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #1107:
URL: https://github.com/apache/incubator-nuttx/pull/1107
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org