You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Yee-Wah Lee (JIRA)" <de...@myfaces.apache.org> on 2008/12/16 21:50:44 UTC
[jira] Created: (TRINIDAD-1349) InputDate: wrong date-time selected
when browser in summer time and server in winter time
InputDate: wrong date-time selected when browser in summer time and server in winter time
-----------------------------------------------------------------------------------------
Key: TRINIDAD-1349
URL: https://issues.apache.org/jira/browse/TRINIDAD-1349
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Reporter: Yee-Wah Lee
Priority: Minor
1. Create an inputDate with convertDateTime with type="both" so date and time show up. You can also go to the demo (look for "A inputDate with a converter attached from fr_BE locale (has 1-digit display for hours)".
2. Run the server in Pacific Time, current date 11 Nov 2008.
3. Open a browser on another machine with timezone Western Australia, current time 11 Nov 2008.
4. Open the date picker, and pick a date in summer, e.g. 15 Mar 2008
The resulting date shows a different day and/or a different time offset. On the demo, I pick 15 Mar and see:
dimanche 16 mars 2008 5:44
Previously the value was mardi 16 décembre 2008 21:45, so it should have retained the hours/mins from the previous value (21:45)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1349) InputDate: wrong date-time
selected when browser in summer time and server in winter time
Posted by "Martin Fekete (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12661589#action_12661589 ]
Martin Fekete commented on TRINIDAD-1349:
-----------------------------------------
i got similar issue with date picker, it was broken date range validation in month in which summer/winter time change happens.
when date picker is rendered on server it generates days adding _MILLIS_IN_DAY to start of month. but day in which time change happens is 1 hours longer/shorter. so this wont work.
submiting patch that fixed my issue.
> InputDate: wrong date-time selected when browser in summer time and server in winter time
> -----------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1349
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1349
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Reporter: Yee-Wah Lee
> Priority: Minor
>
> 1. Create an inputDate with convertDateTime with type="both" so date and time show up. You can also go to the demo (look for "A inputDate with a converter attached from fr_BE locale (has 1-digit display for hours)".
> 2. Run the server in Pacific Time, current date 11 Nov 2008.
> 3. Open a browser on another machine with timezone Western Australia, current time 11 Nov 2008.
> 4. Open the date picker, and pick a date in summer, e.g. 15 Mar 2008
> The resulting date shows a different day and/or a different time offset. On the demo, I pick 15 Mar and see:
> dimanche 16 mars 2008 5:44
> Previously the value was mardi 16 décembre 2008 21:45, so it should have retained the hours/mins from the previous value (21:45)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1349) InputDate: wrong date-time selected
when browser in summer time and server in winter time
Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated TRINIDAD-1349:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 1.2.11-core
1.0.11-core
Assignee: Matthias Weßendorf
Status: Resolved (was: Patch Available)
> InputDate: wrong date-time selected when browser in summer time and server in winter time
> -----------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1349
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1349
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Reporter: Yee-Wah Lee
> Assignee: Matthias Weßendorf
> Priority: Minor
> Fix For: 1.0.11-core, 1.2.11-core
>
> Attachments: TRINIDAD-1349.patch, Trinidad11_1349.patch, Trinidad12_1349.patch
>
>
> 1. Create an inputDate with convertDateTime with type="both" so date and time show up. You can also go to the demo (look for "A inputDate with a converter attached from fr_BE locale (has 1-digit display for hours)".
> 2. Run the server in Pacific Time, current date 11 Nov 2008.
> 3. Open a browser on another machine with timezone Western Australia, current time 11 Nov 2008.
> 4. Open the date picker, and pick a date in summer, e.g. 15 Mar 2008
> The resulting date shows a different day and/or a different time offset. On the demo, I pick 15 Mar and see:
> dimanche 16 mars 2008 5:44
> Previously the value was mardi 16 décembre 2008 21:45, so it should have retained the hours/mins from the previous value (21:45)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1349) InputDate: wrong date-time
selected when browser in summer time and server in winter time
Posted by "Yee-Wah Lee (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663802#action_12663802 ]
Yee-Wah Lee commented on TRINIDAD-1349:
---------------------------------------
Martin, thanks for the patch. I think your fix will work for the case where the client is moving between summer/winter time.
However, there should still be a problem where the server moves between summer/winter time and the picked dates on the client use the wrong timezone offset. I will be looking at that issue.
> InputDate: wrong date-time selected when browser in summer time and server in winter time
> -----------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1349
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1349
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Reporter: Yee-Wah Lee
> Priority: Minor
> Attachments: TRINIDAD-1349.patch
>
>
> 1. Create an inputDate with convertDateTime with type="both" so date and time show up. You can also go to the demo (look for "A inputDate with a converter attached from fr_BE locale (has 1-digit display for hours)".
> 2. Run the server in Pacific Time, current date 11 Nov 2008.
> 3. Open a browser on another machine with timezone Western Australia, current time 11 Nov 2008.
> 4. Open the date picker, and pick a date in summer, e.g. 15 Mar 2008
> The resulting date shows a different day and/or a different time offset. On the demo, I pick 15 Mar and see:
> dimanche 16 mars 2008 5:44
> Previously the value was mardi 16 décembre 2008 21:45, so it should have retained the hours/mins from the previous value (21:45)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1349) InputDate: wrong date-time selected
when browser in summer time and server in winter time
Posted by "Martin Fekete (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Fekete updated TRINIDAD-1349:
------------------------------------
Status: Patch Available (was: Open)
> InputDate: wrong date-time selected when browser in summer time and server in winter time
> -----------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1349
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1349
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Reporter: Yee-Wah Lee
> Priority: Minor
> Attachments: TRINIDAD-1349.patch
>
>
> 1. Create an inputDate with convertDateTime with type="both" so date and time show up. You can also go to the demo (look for "A inputDate with a converter attached from fr_BE locale (has 1-digit display for hours)".
> 2. Run the server in Pacific Time, current date 11 Nov 2008.
> 3. Open a browser on another machine with timezone Western Australia, current time 11 Nov 2008.
> 4. Open the date picker, and pick a date in summer, e.g. 15 Mar 2008
> The resulting date shows a different day and/or a different time offset. On the demo, I pick 15 Mar and see:
> dimanche 16 mars 2008 5:44
> Previously the value was mardi 16 décembre 2008 21:45, so it should have retained the hours/mins from the previous value (21:45)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TRINIDAD-1349) InputDate: wrong date-time
selected when browser in summer time and server in winter time
Posted by "Yee-Wah Lee (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TRINIDAD-1349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680547#action_12680547 ]
Yee-Wah Lee commented on TRINIDAD-1349:
---------------------------------------
See Trinidad-1419 for an addition to this patch, since this can cause golden file errors.
https://issues.apache.org/jira/browse/TRINIDAD-1419
> InputDate: wrong date-time selected when browser in summer time and server in winter time
> -----------------------------------------------------------------------------------------
>
> Key: TRINIDAD-1349
> URL: https://issues.apache.org/jira/browse/TRINIDAD-1349
> Project: MyFaces Trinidad
> Issue Type: Bug
> Components: Components
> Reporter: Yee-Wah Lee
> Assignee: Matthias Weßendorf
> Priority: Minor
> Fix For: 1.0.11-core, 1.2.11-core
>
> Attachments: TRINIDAD-1349.patch, Trinidad11_1349.patch, Trinidad12_1349.patch
>
>
> 1. Create an inputDate with convertDateTime with type="both" so date and time show up. You can also go to the demo (look for "A inputDate with a converter attached from fr_BE locale (has 1-digit display for hours)".
> 2. Run the server in Pacific Time, current date 11 Nov 2008.
> 3. Open a browser on another machine with timezone Western Australia, current time 11 Nov 2008.
> 4. Open the date picker, and pick a date in summer, e.g. 15 Mar 2008
> The resulting date shows a different day and/or a different time offset. On the demo, I pick 15 Mar and see:
> dimanche 16 mars 2008 5:44
> Previously the value was mardi 16 décembre 2008 21:45, so it should have retained the hours/mins from the previous value (21:45)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.