[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #618: DISPATCH-1481: Multicast links should block until a consumer is present

[GitBox <gi...@apache.org>]

bhardesty commented on a change in pull request #618: DISPATCH-1481: Multicast links should block until a consumer is present
URL: https://github.com/apache/qpid-dispatch/pull/618#discussion_r346471860
 
 

 ##########
 File path: docs/books/modules/user-guide/routing.adoc
 ##########
 @@ -116,6 +116,10 @@ This involves configuring an address with a routing pattern. All messages sent t
 +
 This involves configuring a waypoint address to identify the broker queue and then connecting the router to the broker. All messages sent to the waypoint address will be routed to the broker queue.
 
+=== Sending Messages to {RouterName}
+
+{RouterName} moves messages directly from publishers to consumers.  The router does not provide message storage as would a broker.  A message sent to the router must have at least one consumer present in order to properly route the message.  The router uses a _credit_ based flow control mechanism to prevent publishers from passing messages to the router when there are no consumers present.  A client wishing to publish a message to the router must wait until the router has provided it with credit.  Attempting to publish a message without credit available will cause the client to block.  Once credit is made available the client will unblock and the message will be sent to the router.  Most AMQP client libraries provide a means for determining the amount of credit available to a publisher.
+
 === Addresses
 
 Review comment:
   Took a stab at revising this:
   
   === Message Routing Flow Control
   
   {RouterName} uses a \_credit-based\_ flow control mechanism to ensure that producers can only send messages to a router if at least one consumer is available to receive them. Because {RouterName} does not store messages, this credit-based flow control prevents producers from sending messages when there are no consumers present.
   
   A client wishing to send a message to the router must wait until the router has provided it with credit. Attempting to publish a message without credit available will cause the client to block. Once credit is made available, the client will unblock, and the message will be sent to the router.
   
   NOTE: Most AMQP client libraries enable you to determine the amount of credit available to a producer. For more information, consult your client's documentation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org