You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/09/23 11:17:04 UTC
[GitHub] [systemds] corepointer commented on a change in pull request #1063: [SYSTEMDS-2663, 2664] Prepare native instructions for release 2.0
corepointer commented on a change in pull request #1063:
URL: https://github.com/apache/systemds/pull/1063#discussion_r493466336
##########
File path: src/main/java/org/apache/sysds/utils/NativeHelper.java
##########
@@ -146,7 +146,20 @@ private static boolean isSupportedArchitecture() {
LOG.info("Unsupported architecture for native BLAS:" + SystemUtils.OS_ARCH);
return false;
}
-
+
+ /**
+ * Note: we only support Windows and Linux at the moment.
+ *
+ * @return true if operating system is supported
+ */
+ private static boolean isSupportedOS() {
+ if(SystemUtils.IS_OS_LINUX || SystemUtils.IS_OS_WINDOWS) {
Review comment:
We don't have Mac support anymore. We can put it on the wish list in JIRA :wink:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org