You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2018/05/03 12:56:46 UTC

Review Request 66933: Added a flag for resource provider authentication.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66933/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.


Bugs: MESOS-8774
    https://issues.apache.org/jira/browse/MESOS-8774


Repository: mesos


Description
-------

If this flag is set to true, HTTP requests to the resource provider API
have to be authenticated using JWT. A token is already provided to
Storage Local Resource Providers by agents for standalone container
authorization and will be used here as well.


Diffs
-----

  src/slave/constants.hpp d1d15c39c87b9712c96b9f7516a7a0a3e56514cf 
  src/slave/flags.hpp a839591a2b66444ad97fced0620201dde656352d 
  src/slave/flags.cpp 02e1a8b0aa4215c7d07cae24afffdaa248efd8da 
  src/slave/slave.cpp 6ca3d79fd38c800f258c571bb58164427db2ac7c 
  src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 


Diff: https://reviews.apache.org/r/66933/diff/1/


Testing
-------

make check


Thanks,

Jan Schlicht


Re: Review Request 66933: Added a realm for resource provider authentication.

Posted by Benjamin Bannier <be...@mesosphere.io>.

> On May 8, 2018, 12:35 p.m., Benjamin Bannier wrote:
> > src/slave/constants.hpp
> > Lines 171 (patched)
> > <https://reviews.apache.org/r/66933/diff/2/?file=2017498#file2017498line171>
> >
> >     I don't believe it makes sense to treat resource providers separately from other internal components using HTTP communication, what about e.g.,
> >     
> >         // Name of the agent HTTP authentication realm for internal Mesos components.
> >         constexpr char INTERNAL_HTTP_AUTHENTICATION_REALM[] = "mesos-internal";
> 
> Jan Schlicht wrote:
>     While the resource provider API currently is only used internally, it's expected to be used externally as well. If it would be internal only, we would communicate using actors.

Good point about about external resource providers.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66933/#review202623
-----------------------------------------------------------


On May 7, 2018, 2:12 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66933/
> -----------------------------------------------------------
> 
> (Updated May 7, 2018, 2:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-8774
>     https://issues.apache.org/jira/browse/MESOS-8774
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp d1d15c39c87b9712c96b9f7516a7a0a3e56514cf 
>   src/slave/slave.cpp c6d9152d9de4184f9107bb8242b41d468d76e018 
>   src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 
> 
> 
> Diff: https://reviews.apache.org/r/66933/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 66933: Added a realm for resource provider authentication.

Posted by Jan Schlicht <ja...@mesosphere.io>.

> On May 8, 2018, 12:35 p.m., Benjamin Bannier wrote:
> > src/slave/constants.hpp
> > Lines 171 (patched)
> > <https://reviews.apache.org/r/66933/diff/2/?file=2017498#file2017498line171>
> >
> >     I don't believe it makes sense to treat resource providers separately from other internal components using HTTP communication, what about e.g.,
> >     
> >         // Name of the agent HTTP authentication realm for internal Mesos components.
> >         constexpr char INTERNAL_HTTP_AUTHENTICATION_REALM[] = "mesos-internal";

While the resource provider API currently is only used internally, it's expected to be used externally as well. If it would be internal only, we would communicate using actors.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66933/#review202623
-----------------------------------------------------------


On May 7, 2018, 2:12 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66933/
> -----------------------------------------------------------
> 
> (Updated May 7, 2018, 2:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-8774
>     https://issues.apache.org/jira/browse/MESOS-8774
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp d1d15c39c87b9712c96b9f7516a7a0a3e56514cf 
>   src/slave/slave.cpp c6d9152d9de4184f9107bb8242b41d468d76e018 
>   src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 
> 
> 
> Diff: https://reviews.apache.org/r/66933/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 66933: Added a realm for resource provider authentication.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66933/#review202623
-----------------------------------------------------------




src/slave/constants.hpp
Lines 171 (patched)
<https://reviews.apache.org/r/66933/#comment284538>

    I don't believe it makes sense to treat resource providers separately from other internal components using HTTP communication, what about e.g.,
    
        // Name of the agent HTTP authentication realm for internal Mesos components.
        constexpr char INTERNAL_HTTP_AUTHENTICATION_REALM[] = "mesos-internal";


- Benjamin Bannier


On May 7, 2018, 2:12 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66933/
> -----------------------------------------------------------
> 
> (Updated May 7, 2018, 2:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-8774
>     https://issues.apache.org/jira/browse/MESOS-8774
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp d1d15c39c87b9712c96b9f7516a7a0a3e56514cf 
>   src/slave/slave.cpp c6d9152d9de4184f9107bb8242b41d468d76e018 
>   src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 
> 
> 
> Diff: https://reviews.apache.org/r/66933/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 66933: Added a realm for resource provider authentication.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66933/#review202735
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On May 7, 2018, 2:12 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66933/
> -----------------------------------------------------------
> 
> (Updated May 7, 2018, 2:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-8774
>     https://issues.apache.org/jira/browse/MESOS-8774
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/constants.hpp d1d15c39c87b9712c96b9f7516a7a0a3e56514cf 
>   src/slave/slave.cpp c6d9152d9de4184f9107bb8242b41d468d76e018 
>   src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 
> 
> 
> Diff: https://reviews.apache.org/r/66933/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Re: Review Request 66933: Added a realm for resource provider authentication.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66933/
-----------------------------------------------------------

(Updated May 7, 2018, 2:12 p.m.)


Review request for mesos, Benjamin Bannier and Chun-Hung Hsiao.


Changes
-------

Removed flag.


Summary (updated)
-----------------

Added a realm for resource provider authentication.


Bugs: MESOS-8774
    https://issues.apache.org/jira/browse/MESOS-8774


Repository: mesos


Description (updated)
-------

See summary.


Diffs (updated)
-----

  src/slave/constants.hpp d1d15c39c87b9712c96b9f7516a7a0a3e56514cf 
  src/slave/slave.cpp c6d9152d9de4184f9107bb8242b41d468d76e018 
  src/tests/cluster.cpp c071da69500e1d8a223f255904acf7e28100e774 


Diff: https://reviews.apache.org/r/66933/diff/2/

Changes: https://reviews.apache.org/r/66933/diff/1-2/


Testing
-------

make check


Thanks,

Jan Schlicht