You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Raghu Angadi (JIRA)" <ji...@apache.org> on 2009/01/09 19:31:59 UTC
[jira] Commented: (HADOOP-4999) IndexOutOfBoundsException in
FSEditLog
[ https://issues.apache.org/jira/browse/HADOOP-4999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662460#action_12662460 ]
Raghu Angadi commented on HADOOP-4999:
--------------------------------------
The error condition does occur, wouldn't the new loop skip a stream? We need to decrement idx, if a stream is removed.
> IndexOutOfBoundsException in FSEditLog
> --------------------------------------
>
> Key: HADOOP-4999
> URL: https://issues.apache.org/jira/browse/HADOOP-4999
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-4999.patch
>
>
> when we go over a collection of editStreams in FSEditLog::logEdit we pre-calculate number of iterations for the "for loop":
> int numEditStreams = editStreams.size();
> for (int idx = 0; idx < numEditStreams(); idx++) {
> ...
> processIOError(idx);
> ...
> }
> but there is a possibility of an IOError that will call processIOError(idx) which will remove an editStream from editStreams inside the loop, and that will cause IndexOutOfBoundsException when end of collection is reached.
> proposed fix: recalculate size of the collection on every iteration (it is very cheap, cause it just returns an integer).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.