You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/12/01 22:18:58 UTC
[GitHub] [jena] afs opened a new pull request #1121: JENA-2202: Skip if longitude not available
afs opened a new pull request #1121:
URL: https://github.com/apache/jena/pull/1121
Basic fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1121: JENA-2202: Skip if longitude not available
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #1121:
URL: https://github.com/apache/jena/pull/1121#issuecomment-984108774
> or set to zero if null it might be intentional.
Null means "not present".
See report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on a change in pull request #1121: JENA-2202: Skip if longitude not available
Posted by GitBox <gi...@apache.org>.
rvesse commented on a change in pull request #1121:
URL: https://github.com/apache/jena/pull/1121#discussion_r760911532
##########
File path: jena-geosparql/src/main/java/org/apache/jena/geosparql/spatial/SpatialIndex.java
##########
@@ -457,7 +457,11 @@ public static final Dataset wrapModel(Model model) throws SpatialIndexException
Resource feature = resIt.nextResource();
Literal lat = feature.getRequiredProperty(SpatialExtension.GEO_LAT_PROP).getLiteral();
- Literal lon = feature.getRequiredProperty(SpatialExtension.GEO_LON_PROP).getLiteral();
+ Literal lon = feature.getProperty(SpatialExtension.GEO_LON_PROP).getLiteral();
Review comment:
I notice there's no `null` check for `lat` either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1121: JENA-2202: Skip if longitude not available
Posted by GitBox <gi...@apache.org>.
afs merged pull request #1121:
URL: https://github.com/apache/jena/pull/1121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on pull request #1121: JENA-2202: Skip if longitude not available
Posted by GitBox <gi...@apache.org>.
rvesse commented on pull request #1121:
URL: https://github.com/apache/jena/pull/1121#issuecomment-984450876
> or set to zero if null it might be intentional.
Not sure we want [Null Island](https://en.wikipedia.org/wiki/Null_Island) being introduced here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #1121: JENA-2202: Skip if longitude not available
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #1121:
URL: https://github.com/apache/jena/pull/1121#discussion_r760917181
##########
File path: jena-geosparql/src/main/java/org/apache/jena/geosparql/spatial/SpatialIndex.java
##########
@@ -457,7 +457,11 @@ public static final Dataset wrapModel(Model model) throws SpatialIndexException
Resource feature = resIt.nextResource();
Literal lat = feature.getRequiredProperty(SpatialExtension.GEO_LAT_PROP).getLiteral();
- Literal lon = feature.getRequiredProperty(SpatialExtension.GEO_LON_PROP).getLiteral();
+ Literal lon = feature.getProperty(SpatialExtension.GEO_LON_PROP).getLiteral();
Review comment:
The loop is over latitude properties:
```
ResIterator resIt = model.listResourcesWithProperty(SpatialExtension.GEO_LAT_PROP);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] neumarcx commented on pull request #1121: JENA-2202: Skip if longitude not available
Posted by GitBox <gi...@apache.org>.
neumarcx commented on pull request #1121:
URL: https://github.com/apache/jena/pull/1121#issuecomment-984132508
> > or set to zero if null it might be intentional.
>
> Null means "not present".
>
> See report.
reasonable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on a change in pull request #1121: JENA-2202: Skip if longitude not available
Posted by GitBox <gi...@apache.org>.
rvesse commented on a change in pull request #1121:
URL: https://github.com/apache/jena/pull/1121#discussion_r760926367
##########
File path: jena-geosparql/src/main/java/org/apache/jena/geosparql/spatial/SpatialIndex.java
##########
@@ -457,7 +457,11 @@ public static final Dataset wrapModel(Model model) throws SpatialIndexException
Resource feature = resIt.nextResource();
Literal lat = feature.getRequiredProperty(SpatialExtension.GEO_LAT_PROP).getLiteral();
- Literal lon = feature.getRequiredProperty(SpatialExtension.GEO_LON_PROP).getLiteral();
+ Literal lon = feature.getProperty(SpatialExtension.GEO_LON_PROP).getLiteral();
Review comment:
Ah yes, so this is guaranteed to be non-null or we wouldn't be in the loop to start with
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] neumarcx commented on pull request #1121: JENA-2202: Skip if longitude not available
Posted by GitBox <gi...@apache.org>.
neumarcx commented on pull request #1121:
URL: https://github.com/apache/jena/pull/1121#issuecomment-984105553
or set to zero if null it might be intentional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org