You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by "tommaso-previero (via GitHub)" <gi...@apache.org> on 2023/03/23 13:13:58 UTC
[GitHub] [openwhisk] tommaso-previero opened a new pull request, #5387: Gradle build improvements
tommaso-previero opened a new pull request, #5387:
URL: https://github.com/apache/openwhisk/pull/5387
This PR provide little improvements to the Gradle build.
## Description
Here's a brief list of what changed:
- Add com.google.protobuf:protoc dependency for configurations
- Upgrade version of Gradle Enterprise plugin to version `3.12.4`
- Upgrade version of `com.gorylenko.gradle-git-properties` to version `2.4.1`
- Use mavenCentral instead of jcenter as repository
- Use archiveFileName instead of deprecated archiveName property
- Extract swagger download from copySwagger task Explicitly define inputs and outputs for copyGWActions task
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [ ] Scheduler
- [ ] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [x] General tooling
- [ ] Documentation
## Types of changes
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [ ] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
- [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [x] I reviewed the [style guides](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md#coding-standards) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] style95 commented on pull request #5387: Gradle build improvements
Posted by "style95 (via GitHub)" <gi...@apache.org>.
style95 commented on PR #5387:
URL: https://github.com/apache/openwhisk/pull/5387#issuecomment-1569486866
It seems this error is happening.
```
org.apache.openwhisk.standalone.StandaloneApiGwTests > classMethod FAILED
java.lang.IllegalArgumentException: requirement failed
at scala.Predef$.require(Predef.scala:268)
at org.apache.openwhisk.standalone.StandaloneApiGwTests.$anonfun$waitForOtherThings$1(StandaloneApiGwTests.scala:39)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk] codecov-commenter commented on pull request #5387: Gradle build improvements
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5387:
URL: https://github.com/apache/openwhisk/pull/5387#issuecomment-1483498742
## [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#5387](https://codecov.io/gh/apache/openwhisk/pull/5387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (770fc71) into [master](https://codecov.io/gh/apache/openwhisk/commit/60ca6605bb081f99906cff1a21caf75d47e414fa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60ca660) will **decrease** coverage by `14.92%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 770fc71 differs from pull request most recent head 67447e9. Consider uploading reports for the commit 67447e9 to get more accurate results
```diff
@@ Coverage Diff @@
## master #5387 +/- ##
===========================================
- Coverage 76.91% 62.00% -14.92%
===========================================
Files 240 233 -7
Lines 14588 14324 -264
Branches 629 625 -4
===========================================
- Hits 11221 8882 -2339
- Misses 3367 5442 +2075
```
[see 85 files with indirect coverage changes](https://codecov.io/gh/apache/openwhisk/pull/5387/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org