You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/02 20:47:14 UTC

[GitHub] [incubator-nuttx] vbenso commented on pull request #6992: WS2812 LED driver using ESP32's RMT peripheral

vbenso commented on PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#issuecomment-1235883117

   Hi Everyone,
   Thanks for all the comments, I've learned so much.
   All the style issues are already checked with checkpatch.sh.
   The function's prototypes have been moved to the proper places.
   The PIN and CHANNEL defines have been removed from the Kconfig to esp32-devkitc.h.
   There is still the issue with using or not modifyreg32 inside the interrupt function, will it impact in the performance somehow?
   Also, the values of LOGIC_ONE and LOGIC_ZERO will be moved from the RMT layer to the WS2812. 
   
   Once I finish this remaining tasks, I'll re-submit the PR.
   Thanks again for all the help, sorry for taking so much of your time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org