[zeppelin] branch master updated: [ZEPPELIN-5568] Implement SaveInterpreterBindings

[pd...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

pdallig pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new caf94a4  [ZEPPELIN-5568] Implement SaveInterpreterBindings
caf94a4 is described below

commit caf94a41caec6fc9ca29d0212f21f0c59639f8f2
Author: Philipp Dallig <ph...@gmail.com>
AuthorDate: Tue Oct 19 16:07:13 2021 +0200

    [ZEPPELIN-5568] Implement SaveInterpreterBindings
    
    ### What is this PR for?
    This pull request adds support for SaveInterpreterBindings.
    
    ### What type of PR is it?
     - Improvement
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-5568
    
    ### How should this be tested?
    * CI
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Philipp Dallig <ph...@gmail.com>
    
    Closes #4259 from Reamer/save_interpreter_settings and squashes the following commits:
    
    0af1589cc [Philipp Dallig] Implementent SaveInterpreterBindings
---
 .../zeppelin-sdk/src/interfaces/message-data-type-map.interface.ts | 2 ++
 .../zeppelin-sdk/src/interfaces/message-notebook.interface.ts      | 5 +++++
 .../zeppelin-sdk/src/interfaces/message-operator.interface.ts      | 7 +++++++
 zeppelin-web-angular/projects/zeppelin-sdk/src/message.ts          | 4 ++--
 4 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-data-type-map.interface.ts b/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-data-type-map.interface.ts
index fa8bddf..78af79b 100644
--- a/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-data-type-map.interface.ts
+++ b/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-data-type-map.interface.ts
@@ -20,6 +20,7 @@ import {
   EditorSettingSend,
   FolderRename,
   GetInterpreterBindings,
+  SaveInterpreterBindings,
   GetNode,
   ListRevision,
   ListRevisionHistory,
@@ -160,6 +161,7 @@ export interface MessageSendDataTypeMap {
   [OP.UNSUBSCRIBE_UPDATE_NOTE_JOBS]: undefined;
   [OP.LIST_UPDATE_NOTE_JOBS]: undefined;
   [OP.GET_INTERPRETER_BINDINGS]: GetInterpreterBindings;
+  [OP.SAVE_INTERPRETER_BINDINGS]: SaveInterpreterBindings;
   [OP.GET_INTERPRETER_SETTINGS]: undefined;
   [OP.SAVE_NOTE_FORMS]: SaveNoteFormsReceived;
   [OP.REMOVE_NOTE_FORMS]: RemoveNoteForms;
diff --git a/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-notebook.interface.ts b/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-notebook.interface.ts
index c4e739b..cb2a593 100644
--- a/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-notebook.interface.ts
+++ b/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-notebook.interface.ts
@@ -95,6 +95,11 @@ export interface GetInterpreterBindings {
   noteId: string;
 }
 
+export interface SaveInterpreterBindings {
+  noteId: string;
+  selectedSettingIds: string[];
+}
+
 export interface EditorSettingSend {
   paragraphId: string;
   magic: string;
diff --git a/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts b/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts
index 1019330..4c4e086 100644
--- a/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts
+++ b/zeppelin-web-angular/projects/zeppelin-sdk/src/interfaces/message-operator.interface.ts
@@ -358,6 +358,13 @@ export enum OP {
    */
   GET_INTERPRETER_BINDINGS = 'GET_INTERPRETER_BINDINGS',
 
+
+  /**
+  * [c-s]
+  * @param selectedSettingIds
+  */
+  SAVE_INTERPRETER_BINDINGS = 'SAVE_INTERPRETER_BINDINGS',
+
   /**
    * [s-c]
    * interpreter bindings
diff --git a/zeppelin-web-angular/projects/zeppelin-sdk/src/message.ts b/zeppelin-web-angular/projects/zeppelin-sdk/src/message.ts
index 921876a..2ea92c8 100644
--- a/zeppelin-web-angular/projects/zeppelin-sdk/src/message.ts
+++ b/zeppelin-web-angular/projects/zeppelin-sdk/src/message.ts
@@ -518,8 +518,8 @@ export class Message {
   }
 
   saveInterpreterBindings(noteId, selectedSettingIds): void {
-    // this.send<OP.SAVE_INTERPRETER_BINDINGS>(OP.SAVE_INTERPRETER_BINDINGS,
-    //  {noteId: noteId, selectedSettingIds: selectedSettingIds});
+    this.send<OP.SAVE_INTERPRETER_BINDINGS>(OP.SAVE_INTERPRETER_BINDINGS,
+      {noteId: noteId, selectedSettingIds: selectedSettingIds});
   }
 
   listConfigurations(): void {