[GitHub] [spark] mridulm commented on a diff in pull request #41906: [SPARK-44345][CORE] Only log unknown shuffle map output as error when shuffle migration disabled

["mridulm (via GitHub)" <gi...@apache.org>]

mridulm commented on code in PR #41906:
URL: https://github.com/apache/spark/pull/41906#discussion_r1257430884


##########
core/src/main/scala/org/apache/spark/MapOutputTracker.scala:
##########
@@ -805,6 +808,8 @@ private[spark] class MapOutputTrackerMaster(
     shuffleStatuses.get(shuffleId) match {
       case Some(shuffleStatus) =>
         shuffleStatus.updateMapOutput(mapId, bmAddress)
+      case None if shuffleMigrationEnabled =>
+        logDebug(s"Asked to update map output for unknown shuffle ${shuffleId}")

Review Comment:
   I am very hesitant with making this debug.
   If missing, in non migration context, it expected to be logged as an error - making it debug would essentially suppress that message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org