You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/05 08:21:35 UTC

[GitHub] [doris] jackwener opened a new issue, #10616: [Enhancement] There redundant field in TSortNode.

jackwener opened a new issue, #10616:
URL: https://github.com/apache/doris/issues/10616

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Description
   
   ```thrift
   struct TSortNode {
     1: required TSortInfo sort_info
     // Indicates whether the backend service should use topn vs. sorting
     2: required bool use_top_n;
     // This is the number of rows to skip before returning results
     3: optional i64 offset
   
     // TODO(lingbin): remove blew, because duplaicate with TSortInfo
     4: optional list<Exprs.TExpr> ordering_exprs                                   
     5: optional list<bool> is_asc_order                                            
     // Indicates whether the imposed limit comes DEFAULT_ORDER_BY_LIMIT.           
     6: optional bool is_default_limit                                              
     // Indicates, for each expr, if nulls should be listed first or last. This is  
     // independent of is_asc_order.                                                
     7: optional list<bool> nulls_first                                             
     // Expressions evaluated over the input row that materialize the tuple to be so
     // Contains one expr per slot in the materialized tuple.                       
     8: optional list<Exprs.TExpr> sort_tuple_slot_exprs                            
   }
   ```
   
   `ordering_exprs` ... is redundant because it also in the `TSortInfo`
   
   ### Solution
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] EmmyMiao87 closed issue #10616: [Enhancement] There redundant field in TSortNode.

Posted by GitBox <gi...@apache.org>.
EmmyMiao87 closed issue #10616: [Enhancement] There redundant field in TSortNode.
URL: https://github.com/apache/doris/issues/10616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org