[jira] [Commented] (BEAM-2482) CodedValueMutationDetector should use the coders structural value

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101174#comment-16101174 ] 

ASF GitHub Bot commented on BEAM-2482:
--------------------------------------

Github user evindj closed the pull request at:

    https://github.com/apache/beam/pull/3406


> CodedValueMutationDetector should use the coders structural value
> -----------------------------------------------------------------
>
>                 Key: BEAM-2482
>                 URL: https://issues.apache.org/jira/browse/BEAM-2482
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-direct
>            Reporter: Luke Cwik
>            Assignee: Innocent
>            Priority: Minor
>              Labels: newbie, starter
>
> Currently the CodedValueMutationDetector[1] checks to see if the objects are Java equals and then compares whether the bytes are equal. Instead of relying on the bytes, we should rely on the coders structural value explicitly[2]. This allows for a coder to provide a fast path equality check with the default still comparing byte array representations.
> 1: https://github.com/apache/beam/blob/eae0d05bd7c088accd927dcfe3e511efbb11c9fd/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MutationDetectors.java
> 2: https://github.com/apache/beam/blob/01b3f87f977d44eac23eb5488074bbc638858a9d/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java#L252



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)