You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/01 15:45:37 UTC
[GitHub] [spark] beliefer opened a new pull request #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
beliefer opened a new pull request #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429
### What changes were proposed in this pull request?
This is a ANSI SQL and feature id is `F861`
```
<query expression> ::=
[ <with clause> ] <query expression body>
[ <order by clause> ] [ <result offset clause> ] [ <fetch first clause> ]
<result offset clause> ::=
OFFSET <offset row count> { ROW | ROWS }
```
For example:
```
SELECT customer_name, customer_gender FROM customer_dimension
WHERE occupation='Dancer' AND customer_city = 'San Francisco' ORDER BY customer_name;
customer_name | customer_gender
----------------------+-----------------
Amy X. Lang | Female
Anna H. Li | Female
Brian O. Weaver | Male
Craig O. Pavlov | Male
Doug Z. Goldberg | Male
Harold S. Jones | Male
Jack E. Perkins | Male
Joseph W. Overstreet | Male
Kevin . Campbell | Male
Raja Y. Wilson | Male
Samantha O. Brown | Female
Steve H. Gauthier | Male
William . Nielson | Male
William Z. Roy | Male
(14 rows)
SELECT customer_name, customer_gender FROM customer_dimension
WHERE occupation='Dancer' AND customer_city = 'San Francisco' ORDER BY customer_name OFFSET 8;
customer_name | customer_gender
-------------------+-----------------
Kevin . Campbell | Male
Raja Y. Wilson | Male
Samantha O. Brown | Female
Steve H. Gauthier | Male
William . Nielson | Male
William Z. Roy | Male
(6 rows)
```
There are some mainstream database support the syntax.
**PostgreSQL:**
https://www.postgresql.org/docs/11/queries-limit.html
**Vertica:**
https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/SQLReferenceManual/Statements/SELECT/OFFSETClause.htm?zoom_highlight=offset
**MySQL:**
https://dev.mysql.com/doc/refman/5.6/en/select.html
The description for design:
**1**. Consider `OFFSET` as the special case of `LIMIT`. For example:
`SELECT * FROM a limit 10;` similar to `SELECT * FROM a limit 10 offset 0;`
`SELECT * FROM a offset 10;` similar to `SELECT * FROM a limit -1 offset 10;`
**2**. Because the current implement of `LIMIT` has good performance. For example:
`SELECT * FROM a limit 10;` parsed to the logic plan as below:
```
GlobalLimit (limit = 10)
|--LocalLimit (limit = 10)
```
and then the physical plan as below:
```
GlobalLimitExec (limit = 10) // Take the first 10 rows globally
|--LocalLimitExec (limit = 10) // Take the first 10 rows locally
```
This operator reduce massive shuffle and has good performance.
Sometimes, the logic plan transformed to the physical plan as:
```
CollectLimitExec (limit = 10) // Take the first 10 rows globally
```
If the SQL contains order by, such as `SELECT * FROM a order by c limit 10;`.
This SQL will be transformed to the physical plan as below:
```
TakeOrderedAndProjectExec (limit = 10) // Take the first 10 rows after sort globally
```
Based on this situation, this PR produces the following operations. For example:
`SELECT * FROM a limit 10 offset 10;` parsed to the logic plan as below:
```
GlobalLimit (limit = 10, offset = 10)
|--LocalLimit (limit = 10, offset = 10)
```
and then the physical plan as below:
```
GlobalLimitExec (limit = 10, offset = 10) // Skip the first 10 rows and take the next 10 rows globally
|--LocalLimitExec (limit = 10, offset = 10) // Take the first 20(limit + offset) rows locally
```
Sometimes, the logic plan transformed to the physical plan as:
```
CollectLimitExec (limit = 10, offset = 10) // Skip the first 10 rows and take the next 10 rows globally
```
If the SQL contains order by, such as `SELECT * FROM a order by c limit 10 offset 10;`.
This SQL will be transformed to the physical plan as below:
```
TakeOrderedAndProjectExec (limit = 10, offset 10) // Skip the first 10 rows and take the next 10 rows after sort globally
```
**3**.In addition to the above, there is a special case that is only offset but no limit. For example:
`SELECT * FROM a offset 10;` parsed to the logic plan as below:
```
GlobalLimit (limit = -1, offset = 10) // -1 means invalid
|--LocalLimit (limit = -1, offset = 10) // -1 means invalid
```
If offset is very large, will generate a lot of overhead. So I add a configuration item `spark.sql.forceUsingOffsetWithoutLimit` to force running query when user knows the offset is small enough. The default value of `spark.sql.forceUsingOffsetWithoutLimit` is false.
Note: The origin PR to support this feature is https://github.com/apache/spark/pull/25416.
Because the origin PR too old, there exists massive conflict which is hard to resolve. So I open this new PR to support this feature.
### Why are the changes needed?
new feature
### Does this PR introduce any user-facing change?
'No'
### How was this patch tested?
Exists and new UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612847882
**[Test build #121199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121199/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581042048
@gatorsmile @cloud-fan I'm sorry for open a new PR. Because I made some mistake operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582240901
**[Test build #117867 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117867/testReport)** for PR 27429 at commit [`8bcee2f`](https://github.com/apache/spark/commit/8bcee2fbdd4b92f5d71bc49e30004a3d1e28f3ef).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class GlobalLimit(limitExpr: Expression, child: LogicalPlan) extends OrderPreservingUnaryNode `
* `case class LocalLimit(limitExpr: Expression, child: LogicalPlan) extends OrderPreservingUnaryNode `
* `case class GlobalLimitAndOffset(`
* `case class LocalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
* `case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
* `case class GlobalLimitAndOffsetExec(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582287694
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581101353
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22491/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-613089416
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121215/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581923408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117840/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586657759
**[Test build #118486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118486/testReport)** for PR 27429 at commit [`14ca8d3`](https://github.com/apache/spark/commit/14ca8d326fcc5035da5b7a99772aacff8edad163).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586670154
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582253795
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581845564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22591/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586657759
**[Test build #118486 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118486/testReport)** for PR 27429 at commit [`14ca8d3`](https://github.com/apache/spark/commit/14ca8d326fcc5035da5b7a99772aacff8edad163).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612943309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25903/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612891648
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581738146
@cloud-fan Could I add `GlobalLimitAndOffsetExec` in physical operator only and not add `GlobalLimitAndOffset` in logic operator ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590736285
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582184103
**[Test build #117867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117867/testReport)** for PR 27429 at commit [`8bcee2f`](https://github.com/apache/spark/commit/8bcee2fbdd4b92f5d71bc49e30004a3d1e28f3ef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586657304
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590736285
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581131243
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582276819
**[Test build #117905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117905/testReport)** for PR 27429 at commit [`8bcee2f`](https://github.com/apache/spark/commit/8bcee2fbdd4b92f5d71bc49e30004a3d1e28f3ef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590744227
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612891658
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121199/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-613089416
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121215/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582297092
**[Test build #117922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117922/testReport)** for PR 27429 at commit [`484e86a`](https://github.com/apache/spark/commit/484e86a3825da89397729c6a3b6d9806a0737fc4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582184465
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22629/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582183468
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581889227
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590722427
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581060841
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117719/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582183468
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581923999
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22602/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581891200
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117836/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581843381
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612941585
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590865282
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581425743
> ah sorry made a mistake. Let's just don't support OFFSET only for now. Its output is kind of unlimited.
OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612943300
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582255489
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582443815
**[Test build #117922 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117922/testReport)** for PR 27429 at commit [`484e86a`](https://github.com/apache/spark/commit/484e86a3825da89397729c6a3b6d9806a0737fc4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-613089407
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#discussion_r383649593
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala
##########
@@ -161,6 +164,46 @@ case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec {
override def outputOrdering: Seq[SortOrder] = child.outputOrdering
}
+/**
+ * Skip the first `offset` elements then take the first `limit` of the following elements in
+ * the child's single output partition.
+ */
+case class GlobalLimitAndOffsetExec(
+ limit: Int,
+ offset: Int,
+ child: SparkPlan) extends BaseLimitExec {
+
+ override def requiredChildDistribution: List[Distribution] = AllTuples :: Nil
+
+ override def outputPartitioning: Partitioning = child.outputPartitioning
+
+ override def outputOrdering: Seq[SortOrder] = child.outputOrdering
+
+ override def doExecute(): RDD[InternalRow] = {
+ val rdd = child.execute().mapPartitions { iter => iter.take(limit + offset)}
+ val skips = rdd.take(offset)
Review comment:
To implement this feature, we shouldn't probably keep such records within the memory. For example, if the offset was a huge number with 1 as limit, it will throw OOM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590865301
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118911/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582279435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22669/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581790916
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581109391
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117730/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581767343
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581767353
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117798/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581717051
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581109390
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582279427
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581775809
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590736300
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118905/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581843381
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581111445
**[Test build #117736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117736/testReport)** for PR 27429 at commit [`4f22a7a`](https://github.com/apache/spark/commit/4f22a7a18192e084267243bf6854434292c06c1c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581111546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22497/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581790916
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582241304
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117867/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581788610
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581845000
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117829/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590722441
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23654/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581845554
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582258821
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581757088
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581111139
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586657308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23243/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581891687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22598/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612891457
**[Test build #121199 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121199/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582184465
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22629/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581891687
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22598/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582255494
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22658/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586670154
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582258830
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117896/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581101350
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612891648
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582258830
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117896/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581717057
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22561/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581407690
ah sorry made a mistake. Let's just don't support OFFSET only for now. Its output is kind of unlimited.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581131247
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117736/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582287694
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582276819
**[Test build #117905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117905/testReport)** for PR 27429 at commit [`8bcee2f`](https://github.com/apache/spark/commit/8bcee2fbdd4b92f5d71bc49e30004a3d1e28f3ef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612846487
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581060839
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586657308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23243/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581362656
> LocalLimitExec (limit = 10, offset = 10) // Take the first 20(limit + offset) rows locally
This is `LocalLimitExec(20)`, seems we don't need to add "offset" parameter to `LocalLimitExec`?
> GlobalLimitExec (limit = 10, offset = 10) // Skip the first 10 rows and take the next 10 rows globally
Can we create a new operator `GlobalLimitAndOffset` for it? It's a bad idea to overload the sematic of an existing operator.
> ... force running query when user knows the offset is small enough.
Let's not add a feature that is disabled by default and not needed by most users. Maintaining a feature has cost.
For OFFSET without LIMIT, we already have an operator `Tail`, which fails if it's not the root node. I think root node OFFSET is the most common use case and `Tail` is good enough.
So a solution can be
1. For LIMIT ... OFFSET ... , create `GlobalLimitAndOffset(..., LocalLimit(...))`
2. For OFFSET only, create `Tail`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612847882
**[Test build #121199 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121199/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582184455
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581042724
**[Test build #117719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117719/testReport)** for PR 27429 at commit [`7316cca`](https://github.com/apache/spark/commit/7316ccae24eb0186ce32753340365e2ed520b3d6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590865301
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118911/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581101350
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582287707
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117905/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582241295
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590742430
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581800312
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581758570
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581101682
**[Test build #117730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117730/testReport)** for PR 27429 at commit [`4f22a7a`](https://github.com/apache/spark/commit/4f22a7a18192e084267243bf6854434292c06c1c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581109348
**[Test build #117730 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117730/testReport)** for PR 27429 at commit [`4f22a7a`](https://github.com/apache/spark/commit/4f22a7a18192e084267243bf6854434292c06c1c).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581800318
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22581/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590743776
**[Test build #118911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118911/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581758574
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117805/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582295549
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581131243
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581111445
**[Test build #117736 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117736/testReport)** for PR 27429 at commit [`4f22a7a`](https://github.com/apache/spark/commit/4f22a7a18192e084267243bf6854434292c06c1c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582445019
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117922/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581109390
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582277145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22667/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581060753
**[Test build #117719 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117719/testReport)** for PR 27429 at commit [`7316cca`](https://github.com/apache/spark/commit/7316ccae24eb0186ce32753340365e2ed520b3d6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class Offset(offsetExpr: Expression, child: LogicalPlan) extends OrderPreservingUnaryNode `
* `case class GlobalLimit(`
* `case class LocalLimit(`
* `case class CollectLimitExec(limit: Int, offset: Int, child: SparkPlan) extends LimitExec `
* `case class LocalLimitExec(limit: Int, child: SparkPlan, offset: Int = 0) extends BaseLimitExec `
* `case class GlobalLimitExec(limit: Int, child: SparkPlan, offset: Int = 0) extends BaseLimitExec `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582184455
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582255489
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581042033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22480/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590722427
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590736040
**[Test build #118905 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118905/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590722084
**[Test build #118905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118905/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581845564
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22591/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581131247
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117736/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581923986
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581398737
@cloud-fan Thanks a lot !
For the first suggestion , I understand it.
For the second suggestion, I have a question, `OFFSET` and `Tail` mean different things.
If use use `OFFSET` only just want to skip some rows and reserve remaining rows. Users cannot use `Tail` instead of `OFFSET` because users don't know the number of remaining rows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582258821
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582287733
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117907/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581758570
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581775467
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581767343
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#discussion_r383681095
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala
##########
@@ -161,6 +164,46 @@ case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec {
override def outputOrdering: Seq[SortOrder] = child.outputOrdering
}
+/**
+ * Skip the first `offset` elements then take the first `limit` of the following elements in
+ * the child's single output partition.
+ */
+case class GlobalLimitAndOffsetExec(
+ limit: Int,
+ offset: Int,
+ child: SparkPlan) extends BaseLimitExec {
+
+ override def requiredChildDistribution: List[Distribution] = AllTuples :: Nil
+
+ override def outputPartitioning: Partitioning = child.outputPartitioning
+
+ override def outputOrdering: Seq[SortOrder] = child.outputOrdering
+
+ override def doExecute(): RDD[InternalRow] = {
+ val rdd = child.execute().mapPartitions { iter => iter.take(limit + offset)}
+ val skips = rdd.take(offset)
+ rdd.filter(!skips.contains(_))
Review comment:
Thank you! I will resolve this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590864206
**[Test build #118911 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118911/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582255130
**[Test build #117896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117896/testReport)** for PR 27429 at commit [`8bcee2f`](https://github.com/apache/spark/commit/8bcee2fbdd4b92f5d71bc49e30004a3d1e28f3ef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612848226
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581922712
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590865282
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581844990
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612848228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25888/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582275182
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582277140
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582287725
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582279435
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22669/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581923999
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22602/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581844990
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581101682
**[Test build #117730 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117730/testReport)** for PR 27429 at commit [`4f22a7a`](https://github.com/apache/spark/commit/4f22a7a18192e084267243bf6854434292c06c1c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581758574
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117805/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581800312
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581109391
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117730/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581845554
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581847363
@cloud-fan I have refactored the implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581923408
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117840/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581774774
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586670157
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118486/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582275182
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586657304
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581775809
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612891658
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121199/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582287725
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582184103
**[Test build #117867 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117867/testReport)** for PR 27429 at commit [`8bcee2f`](https://github.com/apache/spark/commit/8bcee2fbdd4b92f5d71bc49e30004a3d1e28f3ef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581757091
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22567/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581891677
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581923394
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on a change in pull request #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on a change in pull request #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#discussion_r383677027
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala
##########
@@ -161,6 +164,46 @@ case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec {
override def outputOrdering: Seq[SortOrder] = child.outputOrdering
}
+/**
+ * Skip the first `offset` elements then take the first `limit` of the following elements in
+ * the child's single output partition.
+ */
+case class GlobalLimitAndOffsetExec(
+ limit: Int,
+ offset: Int,
+ child: SparkPlan) extends BaseLimitExec {
+
+ override def requiredChildDistribution: List[Distribution] = AllTuples :: Nil
+
+ override def outputPartitioning: Partitioning = child.outputPartitioning
+
+ override def outputOrdering: Seq[SortOrder] = child.outputOrdering
+
+ override def doExecute(): RDD[InternalRow] = {
+ val rdd = child.execute().mapPartitions { iter => iter.take(limit + offset)}
+ val skips = rdd.take(offset)
Review comment:
Yes, but if the limit was a huge number, it still will throw OOM.
This PR only follows the implement of `BaseLimitExec` https://github.com/apache/spark/blob/14ca8d326fcc5035da5b7a99772aacff8edad163/sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala#L109
If this is an issue, `GlobalLimitExec` and `LocalLimitExec` need to resolve too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582241295
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582258807
**[Test build #117896 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117896/testReport)** for PR 27429 at commit [`8bcee2f`](https://github.com/apache/spark/commit/8bcee2fbdd4b92f5d71bc49e30004a3d1e28f3ef).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class GlobalLimit(limitExpr: Expression, child: LogicalPlan) extends OrderPreservingUnaryNode `
* `case class LocalLimit(limitExpr: Expression, child: LogicalPlan) extends OrderPreservingUnaryNode `
* `case class GlobalLimitAndOffset(`
* `case class LocalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
* `case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
* `case class GlobalLimitAndOffsetExec(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581042031
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581767353
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117798/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581775472
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117812/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581716781
**[Test build #117798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117798/testReport)** for PR 27429 at commit [`1149727`](https://github.com/apache/spark/commit/11497277a606d96cc5540bfb5c7e4932e7bda864).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582279427
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581845000
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117829/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581757088
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582297092
**[Test build #117922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117922/testReport)** for PR 27429 at commit [`484e86a`](https://github.com/apache/spark/commit/484e86a3825da89397729c6a3b6d9806a0737fc4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581891195
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581716781
**[Test build #117798 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117798/testReport)** for PR 27429 at commit [`1149727`](https://github.com/apache/spark/commit/11497277a606d96cc5540bfb5c7e4932e7bda864).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582255494
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22658/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581790925
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117818/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-613088597
**[Test build #121215 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121215/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582287638
**[Test build #117905 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117905/testReport)** for PR 27429 at commit [`8bcee2f`](https://github.com/apache/spark/commit/8bcee2fbdd4b92f5d71bc49e30004a3d1e28f3ef).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class GlobalLimit(limitExpr: Expression, child: LogicalPlan) extends OrderPreservingUnaryNode `
* `case class LocalLimit(limitExpr: Expression, child: LogicalPlan) extends OrderPreservingUnaryNode `
* `case class GlobalLimitAndOffset(`
* `case class LocalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
* `case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec `
* `case class GlobalLimitAndOffsetExec(`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612943300
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612943309
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25903/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581766887
**[Test build #117798 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117798/testReport)** for PR 27429 at commit [`1149727`](https://github.com/apache/spark/commit/11497277a606d96cc5540bfb5c7e4932e7bda864).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590743776
**[Test build #118911 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118911/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582279002
**[Test build #117907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117907/testReport)** for PR 27429 at commit [`484e86a`](https://github.com/apache/spark/commit/484e86a3825da89397729c6a3b6d9806a0737fc4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581111544
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582297518
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581757091
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22567/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586627410
cc @maryannxue @hvanhovell
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581060839
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590744227
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581738146
@cloud-fan Could I add `GlobalLimitAndOffsetExec` in physical operator only and not add `GlobalLimitAndOffset` in logic operator ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581111546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22497/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581775467
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582445019
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117922/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612942767
**[Test build #121215 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121215/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586670157
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118486/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581101353
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22491/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582297529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22685/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581775813
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22575/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590722441
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23654/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582287733
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117907/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581111544
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612848228
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25888/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590744241
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23660/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590722084
**[Test build #118905 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118905/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582277140
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-613089407
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612942767
**[Test build #121215 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121215/testReport)** for PR 27429 at commit [`44b1861`](https://github.com/apache/spark/commit/44b1861cac33ea7692a6d30b0013ff61cfdf280d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582445007
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581923986
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582279002
**[Test build #117907 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117907/testReport)** for PR 27429 at commit [`484e86a`](https://github.com/apache/spark/commit/484e86a3825da89397729c6a3b6d9806a0737fc4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581923394
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581922712
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581891677
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-612848226
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581891195
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581891200
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117836/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581131115
**[Test build #117736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117736/testReport)** for PR 27429 at commit [`4f22a7a`](https://github.com/apache/spark/commit/4f22a7a18192e084267243bf6854434292c06c1c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581060841
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117719/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581775472
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117812/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581042033
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22480/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581717051
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581775813
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22575/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582297529
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22685/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582255130
**[Test build #117896 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117896/testReport)** for PR 27429 at commit [`8bcee2f`](https://github.com/apache/spark/commit/8bcee2fbdd4b92f5d71bc49e30004a3d1e28f3ef).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582241304
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117867/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582277145
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22667/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582445007
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-586670026
**[Test build #118486 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118486/testReport)** for PR 27429 at commit [`14ca8d3`](https://github.com/apache/spark/commit/14ca8d326fcc5035da5b7a99772aacff8edad163).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* ` case class WorkerDecommission(`
* ` case class DecommissionExecutor(executorId: String) extends CoarseGrainedClusterMessage`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581042031
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581717057
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22561/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582287707
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117905/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582287651
**[Test build #117907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117907/testReport)** for PR 27429 at commit [`484e86a`](https://github.com/apache/spark/commit/484e86a3825da89397729c6a3b6d9806a0737fc4).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581790925
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117818/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581800318
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22581/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-582297518
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581788610
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
beliefer removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581774774
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-581042724
**[Test build #117719 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117719/testReport)** for PR 27429 at commit [`7316cca`](https://github.com/apache/spark/commit/7316ccae24eb0186ce32753340365e2ed520b3d6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590744241
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23660/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27429:
[SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#discussion_r383649748
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala
##########
@@ -161,6 +164,46 @@ case class GlobalLimitExec(limit: Int, child: SparkPlan) extends BaseLimitExec {
override def outputOrdering: Seq[SortOrder] = child.outputOrdering
}
+/**
+ * Skip the first `offset` elements then take the first `limit` of the following elements in
+ * the child's single output partition.
+ */
+case class GlobalLimitAndOffsetExec(
+ limit: Int,
+ offset: Int,
+ child: SparkPlan) extends BaseLimitExec {
+
+ override def requiredChildDistribution: List[Distribution] = AllTuples :: Nil
+
+ override def outputPartitioning: Partitioning = child.outputPartitioning
+
+ override def outputOrdering: Seq[SortOrder] = child.outputOrdering
+
+ override def doExecute(): RDD[InternalRow] = {
+ val rdd = child.execute().mapPartitions { iter => iter.take(limit + offset)}
+ val skips = rdd.take(offset)
+ rdd.filter(!skips.contains(_))
Review comment:
and here seems not taking duplicated rows into account. If it will filter out the all same rows selected by `offset`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27429: [SPARK-28330][SQL]
Support ANSI SQL: result offset clause in query expression
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27429: [SPARK-28330][SQL] Support ANSI SQL: result offset clause in query expression
URL: https://github.com/apache/spark/pull/27429#issuecomment-590736300
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118905/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org