You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2021/01/03 06:35:45 UTC

[zeppelin] branch branch-0.9 updated: [ZEPPELIN-5162]. Zeppelin reload note from storage doesn't work

This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch branch-0.9
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/branch-0.9 by this push:
     new 1c04e7e  [ZEPPELIN-5162]. Zeppelin reload note from storage doesn't work
1c04e7e is described below

commit 1c04e7ef42a73fafb59e41c5dc0ee114bb69ea89
Author: Jeff Zhang <zj...@apache.org>
AuthorDate: Mon Dec 21 23:26:28 2020 +0800

    [ZEPPELIN-5162]. Zeppelin reload note from storage doesn't work
    
    ### What is this PR for?
    
    The root cause is that we didn't reload the notes from NotebookRepo. It is a straightforwrad fix with only 1 line code change.
    
    ### What type of PR is it?
    [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-5162
    
    ### How should this be tested?
    * Manually tested.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? NO
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Jeff Zhang <zj...@apache.org>
    
    Closes #3997 from zjffdu/ZEPPELIN-5162 and squashes the following commits:
    
    4aa513114 [Jeff Zhang] Revert "[ZEPPELIN-5169]. Hive set statement doesn't work for some hive version when there's empty line ahead"
    364453879 [Jeff Zhang] [ZEPPELIN-5169]. Hive set statement doesn't work for some hive version when there's empty line ahead
    f8125484d [Jeff Zhang] [ZEPPELIN-5162]. Zeppelin reload note from storage doesn't work
    
    (cherry picked from commit d0928eace051af155f7662650a9e34ece89e4f98)
    Signed-off-by: Jeff Zhang <zj...@apache.org>
---
 .../src/main/java/org/apache/zeppelin/socket/NotebookServer.java         | 1 +
 1 file changed, 1 insertion(+)

diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
index c3f0021..e1146db 100644
--- a/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
+++ b/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java
@@ -780,6 +780,7 @@ public class NotebookServer extends WebSocketServlet
 
   public void broadcastReloadedNoteList(NotebookSocket conn, ServiceContext context)
       throws IOException {
+    getNotebook().reloadAllNotes(context.getAutheInfo());
     broadcastNoteListUpdate();
   }