You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2020/05/27 04:04:21 UTC

[GitHub] [mina-sshd] 243826 opened a new pull request #130: fixed the typo which caused 32 bytes to be reserved instead of 4

243826 opened a new pull request #130:
URL: https://github.com/apache/mina-sshd/pull/130


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


[GitHub] [mina-sshd] gnodet closed pull request #130: fixed the typo which caused 32 bytes to be reserved instead of 4

Posted by GitBox <gi...@apache.org>.
gnodet closed pull request #130:
URL: https://github.com/apache/mina-sshd/pull/130


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


[GitHub] [mina-sshd] gnodet merged pull request #130: fixed the typo which caused 32 bytes to be reserved instead of 4

Posted by GitBox <gi...@apache.org>.
gnodet merged pull request #130:
URL: https://github.com/apache/mina-sshd/pull/130


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


[GitHub] [mina-sshd] 243826 commented on pull request #130: fixed the typo which caused 32 bytes to be reserved instead of 4

Posted by GitBox <gi...@apache.org>.
243826 commented on pull request #130:
URL: https://github.com/apache/mina-sshd/pull/130#issuecomment-638786754


   really not a fan of this strategy since there is not a timely pathway to
   get this fixed due to voluntary nature of resources involved. the code
   without that fix a little bit lower quality than that with the fix now.
   
   On Thu, Jun 4, 2020 at 1:50 AM Guillaume Nodet <no...@github.com>
   wrote:
   
   > I've reverted the merge and raise a broader issue
   > https://issues.apache.org/jira/browse/SSHD-1010 in order to fix all
   > references to xxx.SIZE.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/mina-sshd/pull/130#issuecomment-638711252>, or
   > unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAUT3Q4RPHX3E6SC5QESQVLRU5N6ZANCNFSM4M6H2GEA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


[GitHub] [mina-sshd] gnodet commented on pull request #130: fixed the typo which caused 32 bytes to be reserved instead of 4

Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #130:
URL: https://github.com/apache/mina-sshd/pull/130#issuecomment-634262966


   Retest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


[GitHub] [mina-sshd] gnodet commented on pull request #130: fixed the typo which caused 32 bytes to be reserved instead of 4

Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #130:
URL: https://github.com/apache/mina-sshd/pull/130#issuecomment-638711252


   I've reverted the merge and raise a broader issue https://issues.apache.org/jira/browse/SSHD-1010 in order to fix all references to `xxx.SIZE`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org


[GitHub] [mina-sshd] gnodet removed a comment on pull request #130: fixed the typo which caused 32 bytes to be reserved instead of 4

Posted by GitBox <gi...@apache.org>.
gnodet removed a comment on pull request #130:
URL: https://github.com/apache/mina-sshd/pull/130#issuecomment-634262966


   Retest this please.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org