You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by bu...@apache.org on 2007/05/19 14:26:11 UTC
DO NOT REPLY [Bug 42457] New: - remove meta-stylesheet weirdness from src/webapp/lenya/config/sitemap/pipelines.xmap
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42457>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42457
Summary: remove meta-stylesheet weirdness from
src/webapp/lenya/config/sitemap/pipelines.xmap
Product: Lenya
Version: 1.4.1
Platform: Other
OS/Version: other
Status: NEW
Severity: normal
Priority: P2
Component: Miscellaneous
AssignedTo: dev@lenya.apache.org
ReportedBy: nettings@apache.org
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42457] - [PATCH] remove meta-stylesheet weirdness from src/webapp/lenya/config/sitemap/pipelines.xmap
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42457>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42457
nettings@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|remove meta-stylesheet |[PATCH] remove meta-
|weirdness from |stylesheet weirdness from
|src/webapp/lenya/config/site|src/webapp/lenya/config/site
|map/pipelines.xmap |map/pipelines.xmap
------- Additional Comments From nettings@apache.org 2007-05-19 06:12 -------
please review. this patch should not go in before 1.4, as it does not address a
bug and might break stuff for users.
now we have two remaining ways of styling a cms page: a direct call to
webapp/lenya/util/page2xhtml.xsl, and a call to a local resource
"style-cms-page" that is declared in many sitemaps (redundantly). this resource
additionally does an 1i8n transform and strips namespace nodes.
the best solution would be to figure out a way to build a global resource
(currently, you can't use resources defined in other sitemaps unfortunately),
and to use that everywhere.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42457] - remove meta-stylesheet weirdness from src/webapp/lenya/config/sitemap/pipelines.xmap
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42457>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42457
nettings@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|1.4 |1.4.1
------- Additional Comments From nettings@apache.org 2007-05-19 05:38 -------
look at this snippet:
<!-- Lenya GUI screen -->
<map:match pattern="lenya-screen.xsl">
<map:generate src="fallback://lenya/xslt/util/page2xhtml.xsl"/>
<map:transform src="lenya/xslt/util/page2xslt.xsl">
<map:parameter name="contextprefix" value="{request:contextPath}"/>
</map:transform>
<map:serialize type="xml"/>
</map:match>
page2xhtml.xsl is a stylesheet that renders a page:page to xhtml.
page2xslt.xsl is an identity stylesheet with one exception:
it matches <xsl:param name="contextprefix"/>, and replaces it with <xsl:param
name="contextprefix" select="$contextprefix"/>.
can i suggest a new bug severity level "howler"?
i don't know what the original intention of this was, but i can't think of
anything that could possibly justify such a baroque extravaganza :P
unless i'm very much mistaken, this whole shebang could be replaced by
<map:transform src="fallback://lenya/xslt/util/page2xhtml.xsl"/>
<map:parameter name="contextprefix" value="{request:contextPath}"/>
</map:transform>
wherever src="cocoon://lenya-screen.xsl" is used...
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42457] - [PATCH] remove meta-stylesheet weirdness from src/webapp/lenya/config/sitemap/pipelines.xmap
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42457>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42457
thorsten@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|1.4.1 |2.0.1
Version|1.4.1 |2.0
------- Additional Comments From thorsten@apache.org 2007-07-16 02:03 -------
Renaming Lenya 1.4 to 2.0
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42457] - remove meta-stylesheet weirdness from src/webapp/lenya/config/sitemap/pipelines.xmap
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42457>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42457
------- Additional Comments From nettings@apache.org 2007-05-19 06:09 -------
Created an attachment (id=20219)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=20219&action=view)
gets rid of the lenya-screen.xsl stuff altogether
removes lenya-screen.xsl from pipelines.xmap, and replaces all occurences by
direct calls to webapp/lenya/xslt/util/page2xhtml.xsl.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42457] - [PATCH] remove meta-stylesheet weirdness from src/webapp/lenya/config/sitemap/pipelines.xmap
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42457>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42457
------- Additional Comments From andreas@apache.org 2007-05-22 00:17 -------
(In reply to comment #1)
[...]
> unless i'm very much mistaken, this whole shebang could be replaced by
> <map:transform src="fallback://lenya/xslt/util/page2xhtml.xsl"/>
> <map:parameter name="contextprefix" value="{request:contextPath}"/>
> </map:transform>
> wherever src="cocoon://lenya-screen.xsl" is used...
That approach doesn't scale well. Whenever you change the parameter set of the
page2xhtml.xsl stylesheet, you'd have to update each call to the stylesheet.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
DO NOT REPLY [Bug 42457] - [PATCH] remove meta-stylesheet weirdness from src/webapp/lenya/config/sitemap/pipelines.xmap
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42457>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=42457
------- Additional Comments From nettings@apache.org 2007-08-02 14:30 -------
just as a todo note: this issue could be resolved if we introduced one global
post-processing chain for documentes requested via publication urls. it would
also get rid of the style-cms-page resource which is being duplicated all over
the place. implies that publications must serialize to xml and the global
sitemap must do the post-processing. wdyt?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org