[GitHub] [beam] nancyxu123 commented on pull request #28319: Remove unnecessary try/catch

["nancyxu123 (via GitHub)" <gi...@apache.org>]

nancyxu123 commented on PR #28319:
URL: https://github.com/apache/beam/pull/28319#issuecomment-1709253033

   > cc @nancyxu123 who is the owner of this code now
   
   I agree with Thiago. This function could definitely throw an exception, i.e. DEADLINE_EXCEEDED exception, so we should not remove the try/catch block. It's also ok to log the errors instead of throwing them, since we are only updating the watermark on a best-effort basis, hence why we are doing it in the bundlefinalizer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org