You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Michael Stack (Jira)" <ji...@apache.org> on 2021/03/16 21:27:00 UTC
[jira] [Commented] (HBASE-25668) TestCurrentHourProvider fails 100%
in branch-2.3
[ https://issues.apache.org/jira/browse/HBASE-25668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302906#comment-17302906 ]
Michael Stack commented on HBASE-25668:
---------------------------------------
Pushed on branch-2.3 some debug since it fails reliably on apache -- in the flakies test each time around even -- but not locally:
{code}
commit 74a597fcfff5555a00907cbc04753b9f318ab659 (HEAD -> 2.3, origin/branch-2.3)
Author: stack <st...@apache.org>
Date: Tue Mar 16 14:24:10 2021 -0700
HBASE-25668 TestCurrentHourProvider fails 100% in branch-2.3
Debug...
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestCurrentHourProvider.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestCurrentHourProvider.java
index 6df6b9b570..f7141e7848 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestCurrentHourProvider.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/TestCurrentHourProvider.java
@@ -1,4 +1,4 @@
-/**
+/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
@@ -18,7 +18,6 @@
package org.apache.hadoop.hbase.regionserver.compactions;
import static org.junit.Assert.assertEquals;
-
import java.util.Date;
import java.util.TimeZone;
import org.apache.hadoop.hbase.HBaseClassTestRule;
@@ -63,7 +62,7 @@ public class TestCurrentHourProvider {
CurrentHourProvider.getCurrentHour() - 2 :
CurrentHourProvider.getCurrentHour() - 1;
}
- assertEquals(11, hour11);
+ assertEquals("Timezone=" + timezone, 11, hour11);
// set a time represent hour 15
long deltaFor15 = TimeZone.getDefault().getRawOffset() - 28800000;
@@ -76,7 +75,7 @@ public class TestCurrentHourProvider {
CurrentHourProvider.getCurrentHour() - 2 :
CurrentHourProvider.getCurrentHour() - 1;
}
- assertEquals(15, hour15);
+ assertEquals("Timezone=" + timezone, 15, hour15);
}
}
}
{code}
> TestCurrentHourProvider fails 100% in branch-2.3
> ------------------------------------------------
>
> Key: HBASE-25668
> URL: https://issues.apache.org/jira/browse/HBASE-25668
> Project: HBase
> Issue Type: Sub-task
> Components: flakies
> Affects Versions: 2.3.4
> Reporter: Michael Stack
> Assignee: Michael Stack
> Priority: Minor
> Fix For: 2.3.5
>
> Attachments: image-2021-03-16-13-34-29-412.png
>
>
> !image-2021-03-16-13-34-29-412.png!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)