You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Gunther Hagleitner (JIRA)" <ji...@apache.org> on 2009/06/08 05:42:07 UTC
[jira] Created: (PIG-839) incorrect return codes on failure when
using -f or -e flags
incorrect return codes on failure when using -f or -e flags
-----------------------------------------------------------
Key: PIG-839
URL: https://issues.apache.org/jira/browse/PIG-839
Project: Pig
Issue Type: Bug
Reporter: Gunther Hagleitner
Assignee: Gunther Hagleitner
To repro: pig -e "rmf keep99; a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Santhosh Srinivasan updated PIG-839:
------------------------------------
Resolution: Fixed
Fix Version/s: 0.3.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Issue has been fixed.
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Fix For: 0.3.0
>
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated PIG-839:
-----------------------------------
Status: Patch Available (was: Open)
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Gunther Hagleitner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gunther Hagleitner updated PIG-839:
-----------------------------------
Status: Patch Available (was: Open)
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717431#action_12717431 ]
Santhosh Srinivasan commented on PIG-839:
-----------------------------------------
Patch has been committed to trunk. Will port it to the 0.3 branch shortly. Thanks for fixing the issue Gunther.
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Gunther Hagleitner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gunther Hagleitner updated PIG-839:
-----------------------------------
Description:
To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
was:
To repro: pig -e "rmf keep99; a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717375#action_12717375 ]
Hadoop QA commented on PIG-839:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12410099/fix_return_code.patch
against trunk revision 782703.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/74/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/74/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-minerva.apache.org/74/console
This message is automatically generated.
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717499#action_12717499 ]
Santhosh Srinivasan commented on PIG-839:
-----------------------------------------
Patch has been applied and committed to branch-0.3
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Fix For: 0.3.0
>
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717295#action_12717295 ]
Santhosh Srinivasan commented on PIG-839:
-----------------------------------------
+1 for the review.
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated PIG-839:
-----------------------------------
Status: Open (was: Patch Available)
resubmitting the patch
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717653#action_12717653 ]
Hudson commented on PIG-839:
----------------------------
Integrated in Pig-trunk #468 (See [http://hudson.zones.apache.org/hudson/job/Pig-trunk/468/])
: incorrect return codes on failure when using -f or -e flags (hagletin via sms)
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Fix For: 0.3.0
>
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PIG-839) incorrect return codes on
failure when using -f or -e flags
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717451#action_12717451 ]
Santhosh Srinivasan edited comment on PIG-839 at 6/8/09 2:57 PM:
-----------------------------------------------------------------
There are no unit test cases as the testing was performed manually. Pasting a test run below.
{code}
$ cat errcode.pig
a = load '/user/sms/data/student_tab.data' ;
b = stream a through `false` ;
store b into '/user/sms/data/errcode.out';
#Before fix
$ java -cp pig.jar:/home/y/conf/pig/piglet/released org.apache.pig.Main -f errcode.pig
2009-06-08 14:40:51,917 [main] INFO org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MapReduceLauncher - Failed!
2009-06-08 14:40:51,926 [main] ERROR org.apache.pig.tools.grunt.GruntParser - ERROR 2055: Received Error while processing the map plan: 'false ' failed with exit status: 1
Details at logfile: pig_1244497222536.log
afterside 14:40:53 ~/src_pig/pig/trunk_optimizer_phase3_part2 $ echo $?
0
#After fix
$ java -cp pig.jar:/home/y/conf/pig/piglet/released org.apache.pig.Main -f errcode.pig
2009-06-08 14:42:20,422 [main] INFO org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MapReduceLauncher - Failed!
2009-06-08 14:42:20,434 [main] ERROR org.apache.pig.tools.grunt.GruntParser - ERROR 2055: Received Error while processing the map plan: 'false ' failed with exit status: 1
Details at logfile: /homes/sms/src_commit/pig/trunk/pig_1244497306578.log
afterside 14:42:21 ~/src_commit/pig/trunk $ echo $?
2
{code}
was (Author: sms):
There are no unit test cases as the testing was performed manually. Pasting a test run below.
{code}
$ cat /errcode.pig
a = load '/user/sms/data/student_tab.data' ;
b = stream a through `false` ;
store b into '/user/sms/data/errcode.out';
#Before fix
$ java -cp pig.jar:/home/y/conf/pig/piglet/released org.apache.pig.Main -f errcode.pig
2009-06-08 14:40:51,917 [main] INFO org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MapReduceLauncher - Failed!
2009-06-08 14:40:51,926 [main] ERROR org.apache.pig.tools.grunt.GruntParser - ERROR 2055: Received Error while processing the map plan: 'false ' failed with exit status: 1
Details at logfile: pig_1244497222536.log
afterside 14:40:53 ~/src_pig/pig/trunk_optimizer_phase3_part2 $ echo $?
0
#After fix
$ java -cp pig.jar:/home/y/conf/pig/piglet/released org.apache.pig.Main -f /homes/sms/src_pig/pig/trunk_optimizer_phase3_part2/errcode.pig
2009-06-08 14:42:20,422 [main] INFO org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MapReduceLauncher - Failed!
2009-06-08 14:42:20,434 [main] ERROR org.apache.pig.tools.grunt.GruntParser - ERROR 2055: Received Error while processing the map plan: 'false ' failed with exit status: 1
Details at logfile: /homes/sms/src_commit/pig/trunk/pig_1244497306578.log
afterside 14:42:21 ~/src_commit/pig/trunk $ echo $?
2
{code}
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Gunther Hagleitner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gunther Hagleitner updated PIG-839:
-----------------------------------
Attachment: fix_return_code.patch
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-839) incorrect return codes on failure when
using -f or -e flags
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717451#action_12717451 ]
Santhosh Srinivasan commented on PIG-839:
-----------------------------------------
There are no unit test cases as the testing was performed manually. Pasting a test run below.
{code}
$ cat /errcode.pig
a = load '/user/sms/data/student_tab.data' ;
b = stream a through `false` ;
store b into '/user/sms/data/errcode.out';
#Before fix
$ java -cp pig.jar:/home/y/conf/pig/piglet/released org.apache.pig.Main -f errcode.pig
2009-06-08 14:40:51,917 [main] INFO org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MapReduceLauncher - Failed!
2009-06-08 14:40:51,926 [main] ERROR org.apache.pig.tools.grunt.GruntParser - ERROR 2055: Received Error while processing the map plan: 'false ' failed with exit status: 1
Details at logfile: pig_1244497222536.log
afterside 14:40:53 ~/src_pig/pig/trunk_optimizer_phase3_part2 $ echo $?
0
#After fix
$ java -cp pig.jar:/home/y/conf/pig/piglet/released org.apache.pig.Main -f /homes/sms/src_pig/pig/trunk_optimizer_phase3_part2/errcode.pig
2009-06-08 14:42:20,422 [main] INFO org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MapReduceLauncher - Failed!
2009-06-08 14:42:20,434 [main] ERROR org.apache.pig.tools.grunt.GruntParser - ERROR 2055: Received Error while processing the map plan: 'false ' failed with exit status: 1
Details at logfile: /homes/sms/src_commit/pig/trunk/pig_1244497306578.log
afterside 14:42:21 ~/src_commit/pig/trunk $ echo $?
2
{code}
> incorrect return codes on failure when using -f or -e flags
> -----------------------------------------------------------
>
> Key: PIG-839
> URL: https://issues.apache.org/jira/browse/PIG-839
> Project: Pig
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: fix_return_code.patch
>
>
> To repro: pig -e "a = load '<some file>' ; b = stream a through \`false\` ; store b into '<some file>';"
> Both the -e and -f flags do not return the right code upon exit. Running the script w/o using -f works fine.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.