You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/02/24 02:18:26 UTC
Review Request 31334: Fixing cron update quota checking.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-1134
https://issues.apache.org/jira/browse/AURORA-1134
Repository: aurora
Description
-------
Cron schedule updates were treated as template addition rather than differential update, requiring extra quota capacity to clear the check.
Adding a new `checkCronUpdate()` QuotaManager interface method to correctly handle cron job updates.
This will no apply cleanly, diffed against https://reviews.apache.org/r/31241/
Diffs
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 934b92021d08ca23d95888683e9527ce37a8690a
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2d21a976379631d11a498e7fcfd7cb6b800f3c15
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b0772f73f1a21da5828660bfd7d2b1f6b15cbf74
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 06c8faa9de4d0ac8389dbf07d4e81934b503761b
Diff: https://reviews.apache.org/r/31334/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 31334: Fixing cron update quota checking.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 5:15 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Updated description.
Bugs: AURORA-1134
https://issues.apache.org/jira/browse/AURORA-1134
Repository: aurora
Description (updated)
-------
Cron schedule updates were treated as template addition rather than differential update, requiring extra quota capacity to clear the check.
Adding a new `checkCronUpdate()` QuotaManager interface method to correctly handle cron job updates.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 8444d225e91c75e9a571049d28af7264b6d2d017
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 56398f33206cfa1fa45601a21760c7e23e2616bf
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b79b07c23e00fab524aef21481070c5f09c9fa18
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d36418807ace4f61e8709a2827cea0e7bb8ac6b7
Diff: https://reviews.apache.org/r/31334/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 31334: Fixing cron update quota checking.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/
-----------------------------------------------------------
(Updated Feb. 27, 2015, 5:14 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Rebased.
Bugs: AURORA-1134
https://issues.apache.org/jira/browse/AURORA-1134
Repository: aurora
Description
-------
Cron schedule updates were treated as template addition rather than differential update, requiring extra quota capacity to clear the check.
Adding a new `checkCronUpdate()` QuotaManager interface method to correctly handle cron job updates.
This will no apply cleanly, diffed against https://reviews.apache.org/r/31241/
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 8444d225e91c75e9a571049d28af7264b6d2d017
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 56398f33206cfa1fa45601a21760c7e23e2616bf
src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b79b07c23e00fab524aef21481070c5f09c9fa18
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java d36418807ace4f61e8709a2827cea0e7bb8ac6b7
Diff: https://reviews.apache.org/r/31334/diff/
Testing
-------
./gradlew -Pq build
Thanks,
Maxim Khutornenko
Re: Review Request 31334: Fixing cron update quota checking.
Posted by Bill Farner <wf...@apache.org>.
> On Feb. 24, 2015, 1:48 a.m., Aurora ReviewBot wrote:
> > This patch does not apply cleanly on master (19378c1), do you need to rebase?
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Maxim, can you rebase?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/#review73739
-----------------------------------------------------------
On Feb. 24, 2015, 1:18 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31334/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 1:18 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1134
> https://issues.apache.org/jira/browse/AURORA-1134
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Cron schedule updates were treated as template addition rather than differential update, requiring extra quota capacity to clear the check.
>
> Adding a new `checkCronUpdate()` QuotaManager interface method to correctly handle cron job updates.
>
> This will no apply cleanly, diffed against https://reviews.apache.org/r/31241/
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 934b92021d08ca23d95888683e9527ce37a8690a
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2d21a976379631d11a498e7fcfd7cb6b800f3c15
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b0772f73f1a21da5828660bfd7d2b1f6b15cbf74
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 06c8faa9de4d0ac8389dbf07d4e81934b503761b
>
> Diff: https://reviews.apache.org/r/31334/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 31334: Fixing cron update quota checking.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31334/#review73739
-----------------------------------------------------------
This patch does not apply cleanly on master (19378c1), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 24, 2015, 1:18 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31334/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2015, 1:18 a.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-1134
> https://issues.apache.org/jira/browse/AURORA-1134
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Cron schedule updates were treated as template addition rather than differential update, requiring extra quota capacity to clear the check.
>
> Adding a new `checkCronUpdate()` QuotaManager interface method to correctly handle cron job updates.
>
> This will no apply cleanly, diffed against https://reviews.apache.org/r/31241/
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 934b92021d08ca23d95888683e9527ce37a8690a
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2d21a976379631d11a498e7fcfd7cb6b800f3c15
> src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b0772f73f1a21da5828660bfd7d2b1f6b15cbf74
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 06c8faa9de4d0ac8389dbf07d4e81934b503761b
>
> Diff: https://reviews.apache.org/r/31334/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>