You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/04 02:56:43 UTC

[GitHub] [dolphinscheduler] zhuxt2015 commented on a diff in pull request #10754: [Feature][Master] Failover workflow instance base on priority

zhuxt2015 commented on code in PR #10754:
URL: https://github.com/apache/dolphinscheduler/pull/10754#discussion_r912592037


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml:
##########
@@ -44,7 +44,7 @@
         <foreach collection="states" item="i" open="(" close=")" separator=",">
             #{i}
         </foreach>
-        order by id asc
+        order by process_instance_priority, id asc

Review Comment:
   I think sort by process_instance_priority is most suitable and most commonly used . why do you  want to add sort item, Can you give some cases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org