You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by icexelloss <gi...@git.apache.org> on 2018/04/21 22:05:33 UTC

[GitHub] spark pull request #21082: [SPARK-22239][SQL][Python] Enable grouped aggrega...

Github user icexelloss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21082#discussion_r183220392
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala ---
    @@ -149,7 +149,7 @@ class AnalysisErrorSuite extends AnalysisTest {
               UnresolvedAttribute("a") :: Nil,
               SortOrder(UnresolvedAttribute("b"), Ascending) :: Nil,
               UnspecifiedFrame)).as('window)),
    -    "not supported within a window function" :: Nil)
    +    "does not have any window functions" :: Nil)
    --- End diff --
    
    This is because an early analysis exception is thrown by rule ExtractWindowExpressions


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org