You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/23 07:45:32 UTC

[GitHub] [pulsar] AnonHxy opened a new pull request, #17231: [broker][fix]Fix update topic remove properties

AnonHxy opened a new pull request, #17231:
URL: https://github.com/apache/pulsar/pull/17231

   ### Motivation
   
   * There is a bug that the properties of topic will be removed if we update topic partition number using pulsar admin
   
   ### Modifications
   
   * Keep the properties in `PartitionedTopicMetadata` when updating it.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   - Add UT `org.apache.pulsar.broker.admin.PersistentTopicsTest#testUpdatePartitionedTopicHavingProperties`
   
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on pull request #17231: [broker][fix]Fix update topic remove properties

Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17231:
URL: https://github.com/apache/pulsar/pull/17231#issuecomment-1225162116

   > [broker][fix]Fix update topic remove properties
   Does the PR title naming change ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 commented on pull request #17231: [broker][fix]Fix update topic remove properties

Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #17231:
URL: https://github.com/apache/pulsar/pull/17231#issuecomment-1236342747

   Can you help open a new PR to branch-2.10? There are a lot conflict when cherry-pick directly. @AnonHxy 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #17231: [broker][fix]Fix update topic remove properties

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17231:
URL: https://github.com/apache/pulsar/pull/17231#issuecomment-1225235591

   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #17231: [broker][fix]Fix update topic remove properties

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17231:
URL: https://github.com/apache/pulsar/pull/17231#issuecomment-1236354079

   The conflict cause is that this patch is based on https://github.com/apache/pulsar/pull/14141, which is release in 2.11.0. I will remove the 2.10.2 label and and 2.11.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #17231: [broker][fix]Fix update topic remove properties

Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17231:
URL: https://github.com/apache/pulsar/pull/17231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #17231: [broker][fix]Fix update topic remove properties

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17231:
URL: https://github.com/apache/pulsar/pull/17231#issuecomment-1224339058

   > Same problem below, please pay attention :)
   > 
   > https://github.com/apache/pulsar/blob/8286e8ccb2e1433814c306607c6f218ca548752a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java#L483-L484
   
   Nice catch. Thanks @yuruguo 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org