[GitHub] [airflow] kaxil commented on a diff in pull request #26089: Only send an SlaCallbackRequest if the DAG is scheduled

[GitBox <gi...@apache.org>]

kaxil commented on code in PR #26089:
URL: https://github.com/apache/airflow/pull/26089#discussion_r959843386


##########
tests/jobs/test_scheduler_job.py:
##########
@@ -3000,6 +3000,26 @@ def test_send_sla_callbacks_to_processor_sla_with_task_slas(self, dag_maker):
             expected_callback = SlaCallbackRequest(full_filepath=dag.fileloc, dag_id=dag.dag_id)
             self.scheduler_job.executor.callback_sink.send.assert_called_once_with(expected_callback)
 
+    @pytest.mark.parametrize(
+        "schedule",
+        [
+            None,
+            [Dataset("foo")],

Review Comment:
   Worth adding an inverse of this? pass in timedelta/cron and see if it `self.scheduler_job.executor.callback_sink.send.assert_called_once_with(` --- maybe the test for that might already exist -- in which case I am ok 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org