You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/29 19:47:22 UTC
[GitHub] codecov-io commented on issue #3566: Add metric gauge to track the
number of llc simultaneous segment builds
codecov-io commented on issue #3566: Add metric gauge to track the number of llc simultaneous segment builds
URL: https://github.com/apache/incubator-pinot/pull/3566#issuecomment-442968559
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3566?src=pr&el=h1) Report
> Merging [#3566](https://codecov.io/gh/apache/incubator-pinot/pull/3566?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/b62c611c81c4d0391ec21bbe385aa9c64be54296?src=pr&el=desc) will **increase** coverage by `0.14%`.
> The diff coverage is `46.66%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3566?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3566 +/- ##
===========================================
+ Coverage 70.56% 70.7% +0.14%
Complexity 4 4
===========================================
Files 997 997
Lines 45765 45779 +14
Branches 6135 6137 +2
===========================================
+ Hits 32294 32370 +76
+ Misses 11349 11292 -57
+ Partials 2122 2117 -5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3566?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9MTFJlYWx0aW1lU2VnbWVudERhdGFNYW5hZ2VyLmphdmE=) | `71.47% <100%> (+0.26%)` | `0 <0> (ø)` | :arrow_down: |
| [...com/linkedin/pinot/common/metrics/ServerGauge.java](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRyaWNzL1NlcnZlckdhdWdlLmphdmE=) | `96% <100%> (+0.16%)` | `0 <0> (ø)` | :arrow_down: |
| [...linkedin/pinot/common/metrics/AbstractMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRyaWNzL0Fic3RyYWN0TWV0cmljcy5qYXZh) | `72.29% <27.27%> (-5.08%)` | `0 <0> (ø)` | |
| [...in/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9WYWxpZFNlZ21lbnRQcnVuZXIuamF2YQ==) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `68.88% <0%> (-6.67%)` | `0% <0%> (ø)` | |
| [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL01WU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `54.54% <0%> (-6.07%)` | `0% <0%> (ø)` | |
| [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `81.81% <0%> (-5.46%)` | `0% <0%> (ø)` | |
| [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVsb2NhdGlvbi9SZWFsdGltZVNlZ21lbnRSZWxvY2F0b3IuamF2YQ==) | `68.75% <0%> (-5.21%)` | `0% <0%> (ø)` | |
| [...not/broker/broker/helix/ClusterChangeMediator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9icm9rZXIvaGVsaXgvQ2x1c3RlckNoYW5nZU1lZGlhdG9yLmphdmE=) | `62.9% <0%> (-3.23%)` | `0% <0%> (ø)` | |
| [...manager/realtime/HLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9ITFJlYWx0aW1lU2VnbWVudERhdGFNYW5hZ2VyLmphdmE=) | `78.75% <0%> (-2.6%)` | `0% <0%> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/incubator-pinot/pull/3566/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3566?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3566?src=pr&el=footer). Last update [b62c611...19d95e8](https://codecov.io/gh/apache/incubator-pinot/pull/3566?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org