You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/05/10 14:57:00 UTC

[GitHub] [commons-io] robtimus opened a new pull request #227: IntPredicateFilterReader

robtimus opened a new pull request #227:
URL: https://github.com/apache/commons-io/pull/227


   When using `AbstractCharacterFilterReader`, there are currently three options:
   * Use `CharacterFilterReader`, possibly nested.
   * Use `CharacterSetFilterReader`.
   * Extend `AbstractCharacterFilterReader` and implement `filter`.
   
   Given that the `filter` method can easily be implemented using an `IntPredicate`, I've created class `IntPredicateFilterReader` that allows one to easily create a filter reader that omits whitespace:
   
       new IntPredicateFilterReader(reader, Character::isWhitespace);
   
   Note that this PR depends on (and includes the changes for) PR #226, as the unit tests triggered the infinite loop reported in that PR with the "filter all" predicates.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] garydgregory commented on pull request #227: IntPredicateFilterReader

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #227:
URL: https://github.com/apache/commons-io/pull/227#issuecomment-839996618


   @robtimus 
   Please see master for a variation of this PR which does not add a new class.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] robtimus closed pull request #227: IntPredicateFilterReader

Posted by GitBox <gi...@apache.org>.
robtimus closed pull request #227:
URL: https://github.com/apache/commons-io/pull/227


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] garydgregory commented on pull request #227: IntPredicateFilterReader

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #227:
URL: https://github.com/apache/commons-io/pull/227#issuecomment-839849185


   Please rebase on master.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] coveralls commented on pull request #227: IntPredicateFilterReader

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #227:
URL: https://github.com/apache/commons-io/pull/227#issuecomment-836987714


   
   [![Coverage Status](https://coveralls.io/builds/39534996/badge)](https://coveralls.io/builds/39534996)
   
   Coverage increased (+0.008%) to 89.268% when pulling **e40013ac2e9f068c2fe92be14e05303c1c906c04 on robtimus:IntPredicateFilterReader** into **8365dcfb75c4ca70266b4b472fb622e78e5dc14d on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] coveralls edited a comment on pull request #227: IntPredicateFilterReader

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #227:
URL: https://github.com/apache/commons-io/pull/227#issuecomment-836987714


   
   [![Coverage Status](https://coveralls.io/builds/39626301/badge)](https://coveralls.io/builds/39626301)
   
   Coverage increased (+0.02%) to 89.286% when pulling **e1fd1b58924e81800d62a3ce955d9cc4932f1d47 on robtimus:IntPredicateFilterReader** into **4b7cc53f1e806d2bd232482a6b060e685509f53f on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] robtimus commented on pull request #227: IntPredicateFilterReader

Posted by GitBox <gi...@apache.org>.
robtimus commented on pull request #227:
URL: https://github.com/apache/commons-io/pull/227#issuecomment-840039333


   That indeed makes this PR obsolete.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] coveralls edited a comment on pull request #227: IntPredicateFilterReader

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #227:
URL: https://github.com/apache/commons-io/pull/227#issuecomment-836987714


   
   [![Coverage Status](https://coveralls.io/builds/39626516/badge)](https://coveralls.io/builds/39626516)
   
   Coverage increased (+0.008%) to 89.271% when pulling **e1fd1b58924e81800d62a3ce955d9cc4932f1d47 on robtimus:IntPredicateFilterReader** into **4b7cc53f1e806d2bd232482a6b060e685509f53f on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] robtimus commented on pull request #227: IntPredicateFilterReader

Posted by GitBox <gi...@apache.org>.
robtimus commented on pull request #227:
URL: https://github.com/apache/commons-io/pull/227#issuecomment-839907661


   @garydgregory done. I've cherry-picked the actual commit, since rebasing re-added the commit from PR #226.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org