You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2025/03/05 08:11:29 UTC
[PR] Inject columns of proper length for missing fields [iceberg-python]
lidavidm opened a new pull request, #1767:
URL: https://github.com/apache/iceberg-python/pull/1767
Fixes #1766.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Inject columns of proper length for missing fields [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1767:
URL: https://github.com/apache/iceberg-python/pull/1767#issuecomment-2701342740
> BTW one thing I noticed: the tests compare repr or str of PyArrow objects, however, we don't guarantee that is stable so the tests may break - it would be better to compare objects directly if possible
I see we fixed it for `test_identity_transform_column_projection`. There are a couple more tests with that issue in the same file. Its a good idea to compare the table value and not the repr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Inject columns of proper length for missing fields [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #1767:
URL: https://github.com/apache/iceberg-python/pull/1767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Inject columns of proper length for missing fields [iceberg-python]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1767:
URL: https://github.com/apache/iceberg-python/pull/1767#issuecomment-2700242646
BTW one thing I noticed: the tests compare `repr` or `str` of PyArrow objects, however, we don't guarantee that is stable so the tests may break - it would be better to compare objects directly if possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org