You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by Xpray <gi...@git.apache.org> on 2017/10/08 13:57:10 UTC
[GitHub] flink pull request #4785: [FLINK-7776][TableAPI & SQL] remove duplicated rec...
GitHub user Xpray opened a pull request:
https://github.com/apache/flink/pull/4785
[FLINK-7776][TableAPI & SQL] remove duplicated records collecting in g…
…roup aggregation
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](http://flink.apache.org/contribute-code.html#best-practices).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
## What is the purpose of the change
to improve performance by stop collecting duplicated records
## Brief change log
if current row is same with previous row, then collect nothing
## Verifying this change
This change is already covered by existing tests, such as *(please describe tests)*.
AggregateITCase.testRemoveDuplicateRecordsWithUpsertSink
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
## Documentation
- Does this pull request introduce a new feature? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Xpray/flink FLINK-7776
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4785.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4785
----
commit 222782bcd5f7bb074dce615693dd6a2e05ae6bdc
Author: Xpray <le...@gmail.com>
Date: 2017-10-08T13:49:23Z
[FLINK-7776][TableAPI & SQL] remove duplicate records collecting in group aggregation
----
---
[GitHub] flink pull request #4785: [FLINK-7776][TableAPI & SQL] do not emit duplicate...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4785#discussion_r143405406
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala ---
@@ -129,17 +129,19 @@ class GroupAggProcessFunction(
state.update(accumulators)
cntState.update(inputCnt)
- // if this was not the first row and we have to emit retractions
- if (generateRetraction && !firstRow) {
+ // if this was not the first row and we may have to emit retractions
--- End diff --
I'd remove the `"and we may have to emit retractions"` part of the comment as this is not reflected by the condition.
---
[GitHub] flink issue #4785: [FLINK-7776][TableAPI & SQL] do not emit duplicated recor...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/4785
Merging
---
[GitHub] flink pull request #4785: [FLINK-7776][TableAPI & SQL] do not emit duplicate...
Posted by Xpray <gi...@git.apache.org>.
Github user Xpray commented on a diff in the pull request:
https://github.com/apache/flink/pull/4785#discussion_r143430248
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala ---
@@ -129,17 +129,19 @@ class GroupAggProcessFunction(
state.update(accumulators)
cntState.update(inputCnt)
- // if this was not the first row and we have to emit retractions
- if (generateRetraction && !firstRow) {
+ // if this was not the first row and we may have to emit retractions
--- End diff --
I've removed this comment.
---
[GitHub] flink pull request #4785: [FLINK-7776][TableAPI & SQL] do not emit duplicate...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4785
---