You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by stevengill <gi...@git.apache.org> on 2014/10/02 00:55:33 UTC
[GitHub] cordova-coho pull request: Added npm rc publish step
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/49
Added npm rc publish step
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-25
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-coho/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit cd1104b6c10886d1ad427efb6126e9e41b6abc2f
Author: Steve Gill <st...@adobe.com>
Date: 2014-10-01T22:55:24Z
Added npm rc publish step
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-coho pull request: Added npm rc publish step
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-coho/pull/49#issuecomment-58243962
Note for the passer-by: this PR is on hold until we figure out if we want to use a private staging npm repo instead (I believe)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: Added npm rc publish step
Posted by cmarcelk <gi...@git.apache.org>.
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-coho/pull/49#issuecomment-58383730
If folks are OK with bumping versions numbers on a respin, I'm OK with publishing to npm with the rc tag.
Due to the number of respins I did, I felt burned. But that number of respins should be rare.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: Added npm rc publish step
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/49
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: Added npm rc publish step
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-coho/pull/49#issuecomment-58245822
I thought we were still publishing tools to npm as RCs. It was platforms that we decided against publishing as RCs since it required too many steps to update if we found a bug during RC testing.
That way we can still test the RC with ```npm install cordova@rc``` and ```cordova platform add android --usegit```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: Added npm rc publish step
Posted by cmarcelk <gi...@git.apache.org>.
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-coho/pull/49#issuecomment-58247365
I'd suggest that no RCs be pushed to the real npm registry. If there is a respin, then you can't reuse the version number. I think that is more problematic on tools than platforms. If we really want to test via npm install, I'd suggest a private registry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: Added npm rc publish step
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-coho/pull/49#issuecomment-58343587
Erg, was just going through PRs and assumed the reason this wasn't merged was that you didn't want it to be :P. I do also like publishing to npm before voting so that a publish is just a switching of tag. If we need to go through many version numbers (like just recently happened), that's fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-coho pull request: Added npm rc publish step
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-coho/pull/49#issuecomment-58249073
I agree that having a private npm registry for testing in the long run is
the better option.
For now though, I disagree with not publishing RCs to npm. Why add a
barrier to testing RCs? If we publish no tool rcs to npm, we would expect
our users/testers to grab the tags for lib/cli/plugman/js, npm link them
and then they are able to test. I'm sure we have commiters & contributors
who wouldn't be able to do it properly now!
Being able to tell our users npm install -g cordova@rc to test has been a
great way to get them to try it before we do an official release. Even when
we setup a private npm repo to do this, it will still be one more step to
get people to test for us. Adding barriers!
Worst case, we find a issue with cordova-lib, we will have to fix the
version and do a minor bump and then republish as an RC. CLI & Plugman will
also need to be republished. This happens infrequently enough that I don't
think it is a big deal. Definitely when you consider how easy it is for
people to test.
On Tue, Oct 7, 2014 at 12:40 PM, Marcel Kinard <no...@github.com>
wrote:
> I'd suggest that no RCs be pushed to the real npm registry. If there is a
> respin, then you can't reuse the version number. I think that is more
> problematic on tools than platforms. If we really want to test via npm
> install, I'd suggest a private registry.
>
> --
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-coho/pull/49#issuecomment-58247365>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org