You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/25 09:24:46 UTC

[GitHub] [commons-lang] Isira-Seneviratne opened a new pull request #528: Combine two if conditions in ClassUtils.isAssignable().

Isira-Seneviratne opened a new pull request #528:
URL: https://github.com/apache/commons-lang/pull/528


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory closed pull request #528: Combine two if conditions in ClassUtils.isAssignable().

Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #528:
URL: https://github.com/apache/commons-lang/pull/528


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] coveralls commented on pull request #528: Combine two if conditions in ClassUtils.isAssignable().

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #528:
URL: https://github.com/apache/commons-lang/pull/528#issuecomment-619352315


   
   [![Coverage Status](https://coveralls.io/builds/30335590/badge)](https://coveralls.io/builds/30335590)
   
   Coverage decreased (-0.002%) to 95.089% when pulling **550da9ce4e41432945d3abdac3ea982942200539 on Isira-Seneviratne:Simplify_ClassUtils_isAssignable** into **f6923510352fc3fbfad68bc6c5ac5258a34671b7 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-lang] garydgregory commented on pull request #528: Combine two if conditions in ClassUtils.isAssignable().

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #528:
URL: https://github.com/apache/commons-lang/pull/528#issuecomment-729176419


   -1 I think the code is easier to maintain with one "if" per type.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org