You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "karenbraganz (via GitHub)" <gi...@apache.org> on 2024/12/23 17:12:10 UTC
[PR] Allow internal retries when pending k8s pod is deleted [airflow]
karenbraganz opened a new pull request, #45184:
URL: https://github.com/apache/airflow/pull/45184
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
On Airflow instances with the Kubernetes executor, a task will immediately fail if its worker pod is deleted/ evicted in the pending state. A new worker pod is not spun up to replace it, and the task fails with the below error message.
```
{task_context_logger.py:104} ERROR - Executor reports task instance <TaskInstance: dag_id.task_id scheduled__2024-10-20T02:00:00+00:00 [queued]> finished (failed) although the task says it's queued. (Info: None) Was the task killed externally?
```
This failure is triggered by [this line in the source code](https://github.com/apache/airflow/blob/43d7c1c5b6a83694c9c526ab9bc29cc1a87c4ef3/providers/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_utils.py#L237).
If the task is not failed upon worker pod deletion, it will remain in the queued state until it reaches `task_queued_timeout`. Once this timeout is reached, internal retries will be allowed due to [PR #43520](https://github.com/apache/airflow/pull/43520) and a new worker pod will be spun up for the task. Therefore, if the first worker pod was deleted or evicted due to a temporary issue, the task will be able to run on the newly spun up worker pod.
In this PR, I have removed the code that fails the task when its pending worker pod is deleted. This will prevent task failures from temporary issues with pending worker pods.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow internal retries when pending k8s pod is deleted [airflow]
Posted by "karenbraganz (via GitHub)" <gi...@apache.org>.
karenbraganz closed pull request #45184: Allow internal retries when pending k8s pod is deleted
URL: https://github.com/apache/airflow/pull/45184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow internal retries when pending k8s pod is deleted [airflow]
Posted by "dimberman (via GitHub)" <gi...@apache.org>.
dimberman merged PR #45184:
URL: https://github.com/apache/airflow/pull/45184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Allow internal retries when pending k8s pod is deleted [airflow]
Posted by "RNHTTR (via GitHub)" <gi...@apache.org>.
RNHTTR commented on code in PR #45184:
URL: https://github.com/apache/airflow/pull/45184#discussion_r1914942880
##########
providers/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -76,10 +76,6 @@ def __init__(self):
# interact with cluster components.
self.executor_namespace = conf.get(self.kubernetes_section, "namespace")
- self.worker_pods_queued_check_interval = conf.getint(
Review Comment:
You might need to deprecate this config in the documentation. I'm not sure if it will handle this automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org