You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/23 01:01:11 UTC
[GitHub] [druid] jon-wei opened a new pull request #10420: Add ingestion merge count metric
jon-wei opened a new pull request #10420:
URL: https://github.com/apache/druid/pull/10420
This PR adds a new `ingest/merge/count` metric that records how many intermediate persists have been merged for publishing.
Additionally, this PR enables the existing `ingest/merge/time` and `ingest/merge/cpu` metrics for `AppenderatorImpl`, which were only being updated in `RealtimePlumber`.
Marking WIP since in a test cluster I'm seeing discrepancies in the total sums of `ingest/persist/count` and the new `ingest/merge/count`, which I would expect to be the same, need to investigate that further. Also I observed ingestion related metrics not being emitted when a batch task shuts down, which should be looked into as well.
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on pull request #10420: Add ingestion merge count metric
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #10420:
URL: https://github.com/apache/druid/pull/10420#issuecomment-748615186
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org