You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by SunboX <gi...@git.apache.org> on 2015/06/19 10:19:09 UTC
[GitHub] cordova-wp8 pull request: Added the XHR upload attribute
GitHub user SunboX opened a pull request:
https://github.com/apache/cordova-wp8/pull/84
Added the XHR upload attribute
Added the XHR upload attribute as defined by https://xhr.spec.whatwg.org/#the-upload-attribute and documented at MDN here https://developer.mozilla.org/de/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest#Monitoring_progress
This is required by https://github.com/doedje/jquery.soap/blob/master/jquery.soap.js#L281 and will throw a exception if not present.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SunboX/cordova-wp8 xhr-upload-attribute
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-wp8/pull/84.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #84
----
commit 9a1b36cb13908436a946a4621325018d16a26f56
Author: André Fiedler <su...@users.noreply.github.com>
Date: 2015-06-19T08:18:49Z
Added the XHR upload attribute
Added the XHR upload attribute as defined by https://xhr.spec.whatwg.org/#the-upload-attribute and documented at MDN here https://developer.mozilla.org/de/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest#Monitoring_progress
This is required by https://github.com/doedje/jquery.soap/blob/master/jquery.soap.js#L281 and will throw a exception if not present.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added the XHR upload attribute
Posted by SunboX <gi...@git.apache.org>.
Github user SunboX commented on the pull request:
https://github.com/apache/cordova-wp8/pull/84#issuecomment-135967738
Are you serious? For this snipped of code? No, dry, to much work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added the XHR upload attribute
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/84#issuecomment-136738214
@SunboX, this was merged in https://git1-us-west.apache.org/repos/asf?p=cordova-wp8.git;a=commit;h=81a8d3e17c9d879c92d3349bd7166557d14e5bf9. Please close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added the XHR upload attribute
Posted by SunboX <gi...@git.apache.org>.
Github user SunboX closed the pull request at:
https://github.com/apache/cordova-wp8/pull/84
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added the XHR upload attribute
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/84#issuecomment-135759247
@SunboX, please sign Apache ICLA (see [CONTRIBUTING.md](https://github.com/apache/cordova-wp8/blob/master/CONTRIBUTING.md)) before this could be merged. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added the XHR upload attribute
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/84#issuecomment-136737313
Merging anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: Added the XHR upload attribute
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/84#issuecomment-113594895
Thanks. LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org