You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "hgdharold (via GitHub)" <gi...@apache.org> on 2024/05/08 11:19:05 UTC
[PR] Admin UI: fixed node list display bug caused by different hostname with same front part [solr]
hgdharold opened a new pull request, #2449:
URL: https://github.com/apache/solr/pull/2449
# Description
old code:
```// Checks if this node is the first (alphabetically) for a given host. Used to decide rowspan in table
$scope.isFirstNodeForHost = function(node) {
var hostName = node.split(":")[0];
var nodesInHost = $scope.filteredNodes.filter(function (node) {
return node.startsWith(hostName);
});
return nodesInHost[0] === node;
};
```
hostname like `server-1`, `server-10`, this code will cause the node list to be displayed incorrectly
# Solution
```
$scope.isFirstNodeForHost = function(node) {
var hostName = node.split(":")[0];
var nodesInHost = $scope.filteredNodes.filter(function (node) {
return node.split(":")[0] === hostName;
});
return nodesInHost[0] === node;
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Admin UI: fixed node list display bug caused by different hostname with same front part [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2449:
URL: https://github.com/apache/solr/pull/2449#issuecomment-2111092186
@hgdharold how would you like to be credited in the `solr/CHANGES.txt` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Admin UI: fixed node list display bug caused by different hostname with same front part [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh closed pull request #2449: Admin UI: fixed node list display bug caused by different hostname with same front part
URL: https://github.com/apache/solr/pull/2449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Admin UI: fixed node list display bug caused by different hostname with same front part [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2449:
URL: https://github.com/apache/solr/pull/2449#issuecomment-2125702345
Due to challenges pushing changes, replacing this one with https://github.com/apache/solr/pull/2475.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Admin UI: fixed node list display bug caused by different hostname with same front part [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on PR #2449:
URL: https://github.com/apache/solr/pull/2449#issuecomment-2100565504
Thanks for this contribution!
The `Gradle Precommit` CI failure looks unrelated and pre-existing and @epugh is fixing it in #2450 pull request. Just FYI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Admin UI: fixed node list display bug caused by different hostname with same front part [solr]
Posted by "cpoerschke (via GitHub)" <gi...@apache.org>.
cpoerschke commented on PR #2449:
URL: https://github.com/apache/solr/pull/2449#issuecomment-2110667390
> ... @cpoerschke not sure if you have a strategy to test it?
No, I don't, sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] Admin UI: fixed node list display bug caused by different hostname with same front part [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #2449:
URL: https://github.com/apache/solr/pull/2449#issuecomment-2110176384
I'd like to merge this, however can you give me some concrete examples of different hostname with same front part? I'm just not totally sure how to test the fix ;-). @cpoerschke not sure if you have a strategy to test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org