You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2015/12/02 10:01:12 UTC
[GitHub] spark pull request: [SPARK-12067] [SQL] Add isNan, isnull, notnull...
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/10097
[SPARK-12067] [SQL] Add isNan, isnull, notnull, isnan to PySpark Column
Add isNan, isnull, notnull, isnan to PySpark Column.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanboliang/spark spark-12067-follow
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/10097.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #10097
----
commit ad4d1fc681094f0e2ece3db9c76989971631aaf1
Author: Yanbo Liang <yb...@gmail.com>
Date: 2015-12-02T09:00:11Z
Add isNan, isnull, notnull, isnan to PySpark Column
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12067] [SQL] Add isNan, isnull, notnull...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/10097#discussion_r50481258
--- Diff: python/pyspark/sql/column.py ---
@@ -316,6 +316,10 @@ def isin(self, *cols):
isNull = _unary_op("isNull", "True if the current expression is null.")
isNotNull = _unary_op("isNotNull", "True if the current expression is not null.")
+ isNaN = _unary_op("isNaN", "True if the current expression is NaN.")
+ isnull = _unary_op("isNull", "True if the current expression is null.")
--- End diff --
Maybe have a comment that says this is for pandas API compat? Since skimming the code it looks a little of of place with the rest of the functions. Just a thought.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12067] [SQL] Add isNan, isnull, notnull...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10097#issuecomment-161228853
**[Test build #47048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47048/consoleFull)** for PR 10097 at commit [`ad4d1fc`](https://github.com/apache/spark/commit/ad4d1fc681094f0e2ece3db9c76989971631aaf1).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12067] [SQL] Add isNan, isnull, notnull...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10097#issuecomment-161236835
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/47048/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12067] [SQL] Add isNan, isnull, notnull...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/10097#issuecomment-161236429
**[Test build #47048 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/47048/consoleFull)** for PR 10097 at commit [`ad4d1fc`](https://github.com/apache/spark/commit/ad4d1fc681094f0e2ece3db9c76989971631aaf1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12067] [SQL] Add isNan, isnull, notnull...
Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang closed the pull request at:
https://github.com/apache/spark/pull/10097
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-12067] [SQL] Add isNan, isnull, notnull...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/10097#issuecomment-161236831
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org